Repository navigation
Freeze the live corpus as wic-50 v2 - #6
Merged
Merged
Conversation
A run of the embedded scenarios recorded the corpus as custom, because only wic-50 v1 was frozen and the live set no longer matches it. The site then showed "catalog unavailable" for every row of a fresh run. Freeze the live set as wic-50-v2.json. The runner and the site now match a corpus hash against every frozen catalog. A guard test fails when the embedded scenarios drift from v2, so an edit must freeze a new revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The guard test checks the catalog list, but no test proved that load() gives the v2 catalog to the site. A result that names wic-50 v2 now must render its scenario description and no "catalog unavailable" marker in appendix.html and results.json. With load() limited to the first frozen catalog, the test fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A run of the embedded scenarios records its corpus as
custom. Onlywic-50v1 is frozen, and the live scenario set no longer matches v1. The site then shows "catalog unavailable" for every row of a fresh run.This PR is stacked on #4. Merge #4 first.
Fix
crates/wic-core/catalogs/wic-50-v2.jsonfreezes the live set aswic-50revisionv2. Its hash issha256:9661db2f98e15d84a5191948478bace511572fc5d6f24ca3102025b28eccdfe5.Testing
cargo fmt --checkandcargo clippy --workspace --all-targets -- -D warningsare clean.cargo test --workspace: 154 tests pass. Fix the three Codex findings on #2 #4 has 150.site_joins_a_wic_50_v2_result_to_the_frozen_v2_cataloggives the site a result that nameswic-50v2. The test checks for the scenario description and for no "catalog unavailable" marker inappendix.htmlandresults.json.custom, notwic-50.select_catalogsearches only the first frozen catalog: the later-catalog test fails.load()keeps only the first frozen catalog: the v2 site test fails.willitcall site --results results/gives output that is byte-identical to Fix the three Codex findings on #2 #4.toolsunittest and the redaction ledger check pass.This PR and the Windows model path PR change the same import block in
site/data.rs. The second one to merge needsmainmerged in first. The merged state of both passes all 155 tests.