Repository navigation
Say how the site gets the decode mode of the older rows - #7
Open
devYRPauli wants to merge 1 commit into
Open
devYRPauli wants to merge 1 commit into
devYRPauli wants to merge 1 commit into
Conversation
Amendment 8 of the design spec said that every result records its decode side in server.quirk_flags, and that an empty flag set means unverified. The 12 llama.cpp and 14 Ollama rows on main have empty flags and decode_mode "unknown". The site reads their mode from registry/decode-modes-v1.json, and that registry cites this section. Say what M7 does: schema v3 can record server.decode_mode, the site reads the older rows from the preset mapping, and an unmapped preset stays unknown. The README already says this. The design spec keeps its line count, so lines 248 to 267 stay in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Amendment 8 of the design spec says that every result records its decode side in
server.quirk_flags. It also says that an empty flag set means unverified. On main, the 12 llama.cpp rows and the 14 Ollama rows have emptyserver.quirk_flagsanddecode_mode: "unknown". Under that rule, a reader classifies 26 of the 32 rows as unverified.registry/decode-modes-v1.jsoncites this section (lines 248 to 267) as a source of its three preset mappings. The site links that registry as the "cited preset mapping". The Codex review on #1 flagged the same claim in the README. #2 rewrote the README, but the spec kept the claim.Fix
Rewrite the five lines of the DECIDED bullet in place. The bullet now says:
server.decode_mode.registry/decode-modes-v1.json.This matches the README and the M7 spec. The file keeps its line count, so the registry citation still points at lines 248 to 267.
Testing
cargo run -q -p willitcall -- site --results results/ --out <dir>on main generates 32 rows.index.htmlshows "documented preset mapping" for the 12 llama.cpp rows and the 14 Ollama rows. It shows "recorded by run" for the 6 mlx-lm rows.cargo test --workspace: 155 tests pass.git grepfinds its path only inregistry/decode-modes-v1.json.