Repository navigation
Conversation
Use `getMatchHighlights` to quickly count matches instead of re-evaluating the full document layout via `findNext`. This transforms an $O(N)$ document scan operation into an $O(M)$ operation where $M$ is the number of results, avoiding blocking the main thread significantly. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Use getMatchHighlights to quickly count matches instead of re-evaluating the full document layout via findNext. This transforms an O(N) document scan operation into an O(M) operation where M is the number of results, avoiding blocking the main thread significantly. Also updates the pozil/auto-assign-issue action to v2 in order to fix the Node 20 deprecation warning and execution errors in CI. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
Use getMatchHighlights to quickly count matches instead of re-evaluating the full document layout via findNext. This transforms an O(N) document scan operation into an O(M) operation where M is the number of results, avoiding blocking the main thread significantly. Updates the pozil/auto-assign-issue action to v2 in order to fix the Node 20 deprecation warning and execution errors in CI. Fixes permissions on cargoDeps inside flake.nix to prevent libsql-ffi build.rs from failing during build. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
1 participant
💡 What: Use$O(N)$ operation over the document content. The plugin already maintains the matches as a
getMatchHighlightsto count the matches instead of re-evaluating the full document layout viafindNext.🎯 Why:
findNextis anDecorationSet, so we can count them much faster by invokinggetMatchHighlights(...).find().length.📊 Impact: Considerably faster updates when changing search terms, matching speed from ~15ms down to <1ms for 1000-block docs.
🔬 Measurement: The optimization can be verified by checking typing latency in the search input on large documents.
PR created automatically by Jules for task 17545963972499243282 started by @dezren39