#2172: add getIdeMetadataPath() for $IDE_HOME/.ide/<ide>/<workspace> - #2175
Conversation
Coverage Report for CI Build 30624582980Coverage decreased (-0.04%) to 72.606%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions8 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
|
Looks good 👍 @quando632: the The new unit test covers the path resolution, and the change is ready for the follow-up IDE-specific wiring PRs. |
hohwille
left a comment
There was a problem hiding this comment.
@quando632 thanks for your PR and following divide & conquer. LGTM👍
BTW: I would have thought to create the method pointing to the current metadata path and already using it and then with the refactoring changing the implementation.
However, your approach to only introduce the new method has the advantage that you can create PRs individually to move the metadata for each IDE independently.
So I like your approach and am happy to merge.
This PR fixes #2172 (part of #2142)
Foundation step for moving IDE-specific metadata out of the workspace. No behavior change yet.
Implemented changes:
IdeToolCommandlet.getIdeMetadataPath()resolving to$IDE_HOME/.ide/«ide»/«workspace»(reusesIdeContext.FOLDER_DOT_IDE,getIdeHome(),getWorkspaceName()).IdeToolCommandletTest.testGetIdeMetadataPath().The follow-up subtasks switch the actual metadata writers onto this getter: #2173 (JetBrains) and #2174 (VSCode).
Testing instructions
cd cli && mvn -Dtest=IdeToolCommandletTest testboth tests pass.Checklist for this PR
mvn clean testlocally all tests pass and build is successful (ranIdeToolCommandletTest)#«issue-id»: «brief summary»In Progressand assigned to you