Skip to content

#2172: add getIdeMetadataPath() for $IDE_HOME/.ide/<ide>/<workspace> - #2175

Merged
hohwille merged 9 commits into
devonfw:mainfrom
quando632:feature/2172-ide-metadata-path
Jul 31, 2026
Merged

#2172: add getIdeMetadataPath() for $IDE_HOME/.ide/<ide>/<workspace>#2175
hohwille merged 9 commits into
devonfw:mainfrom
quando632:feature/2172-ide-metadata-path

Conversation

@quando632

@quando632 quando632 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2172 (part of #2142)

Foundation step for moving IDE-specific metadata out of the workspace. No behavior change yet.

Implemented changes:

The follow-up subtasks switch the actual metadata writers onto this getter: #2173 (JetBrains) and #2174 (VSCode).


Testing instructions

  1. cd cli && mvn -Dtest=IdeToolCommandletTest test both tests pass.
  2. Verify no existing IDE launch behavior changed (getter is not yet wired into any caller).

Checklist for this PR

  • When running mvn clean test locally all tests pass and build is successful (ran IdeToolCommandletTest)
  • PR title is of the form #«issue-id»: «brief summary»
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@coveralls

coveralls commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 30624582980

Coverage decreased (-0.04%) to 72.606%

Details

  • Coverage decreased (-0.04%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 8 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

8 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 6 78.69%
com/devonfw/tools/ide/version/VersionSegment.java 2 90.03%

Coverage Stats

Coverage Status
Relevant Lines: 17283
Covered Lines: 13086
Line Coverage: 75.72%
Relevant Branches: 7653
Covered Branches: 5019
Branch Coverage: 65.58%
Branches in Coverage %: Yes
Coverage Strength: 3.21 hits per line

💛 - Coveralls

@quando632 quando632 added enhancement New feature or request workspace workspaces sub-folder to manage sub-projects labels Jul 21, 2026
@quando632 quando632 moved this from 🆕 New to Team Review in IDEasy board Jul 21, 2026
@quando632 quando632 moved this from Team Review to 🏗 In progress in IDEasy board Jul 21, 2026
Comment thread CHANGELOG.adoc Outdated
@vivu001

vivu001 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Looks good 👍 @quando632: the getIdeMetadataPath() is added as a shared foundation for moving IDE metadata to $IDE_HOME/.ide/«ide»/«workspace», and it’s not wired into any launch path yet, so behavior stays unchanged.

The new unit test covers the path resolution, and the change is ready for the follow-up IDE-specific wiring PRs.

@quando632
quando632 marked this pull request as ready for review July 22, 2026 11:42
@vivu001 vivu001 moved this from Team Review to 👀 In review in IDEasy board Jul 22, 2026

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quando632 thanks for your PR and following divide & conquer. LGTM👍
BTW: I would have thought to create the method pointing to the current metadata path and already using it and then with the refactoring changing the implementation.
However, your approach to only introduce the new method has the advantage that you can create PRs individually to move the metadata for each IDE independently.
So I like your approach and am happy to merge.

Comment thread CHANGELOG.adoc Outdated
@hohwille
hohwille merged commit 32ef55b into devonfw:main Jul 31, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request workspace workspaces sub-folder to manage sub-projects

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Foundation: introduce getIdeMetadataPath() for $IDE_HOME/.ide/<ide>/<workspace>

4 participants