#2211: Delete PythonUrlUpdater and related files - #2220
Conversation
Coverage Report for CI Build 30343976495Coverage decreased (-0.08%) to 72.519%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions26 previously-covered lines in 4 files lost coverage.
Coverage Stats💛 - Coveralls |
oanding-blrng
left a comment
There was a problem hiding this comment.
The project and the module are passing can be compiled and passed are tests. The UpdateManager.java doesn't create/use the PythonUrlUpdater.java and therefore no crawling regarding the URL defined in the PythonUrlUpdater.java should be made.
After fixing the CHANGELOG.adoc and updating the branch to the latest commit of main, this PR can move forward.
|
|
||
| * https://github.com/devonfw/IDEasy/issues/2176[#2176]: Support 7z archive extraction | ||
| * https://github.com/devonfw/IDEasy/issues/2100[#2100]: Fix Python not available for Mac x64 | ||
| * https://github.com/devonfw/IDEasy/issues/NNNN[#2211]: Delete PythonUrlUpdater and python metadata from ide-urls |
There was a problem hiding this comment.
| * https://github.com/devonfw/IDEasy/issues/NNNN[#2211]: Delete PythonUrlUpdater and python metadata from ide-urls |
The ticket and this pr are labeled with internal. As per DoD, no additional entry had to be made in the CHANGELOG.adoc.
hohwille
left a comment
There was a problem hiding this comment.
@Paras14 thanks for your PR. Great to do some cleanup. 👍
I have some formatting question that we should clarify but must not block this PR.
Also you should apply the review suggestion from @oanding-blrng
Then we can merge.
| new DockerDesktopUrlUpdater(), new DotNetUrlUpdater(), new EclipseCppUrlUpdater(), new EclipseJeeUrlUpdater(), new EclipseJavaUrlUpdater(), | ||
| new GcLogAnalyzerUrlUpdater(), | ||
| new GCloudUrlUpdater(), new GcViewerUrlUpdater(), new GhUrlUpdater(), new GoUrlUpdater(), new GraalVmCommunityUpdater(), new GraalVmOracleUrlUpdater(), | ||
| new GradleUrlUpdater(), new HelmUrlUpdater(), new InsoUrlUpdater(), new IntellijUrlUpdater(), new JasyptUrlUpdater(), new JavaAzulUrlUpdater(), | ||
| new JavaUrlUpdater(), new JenkinsUrlUpdater(), new JmcUrlUpdater(), new KotlincUrlUpdater(), new KotlincNativeUrlUpdater(), new LazyDockerUrlUpdater(), new MvnUrlUpdater(), | ||
| new MvndUrlUpdater(), new NgUrlUpdater(), new NodeUrlUpdater(), new NpmUrlUpdater(), new OcUrlUpdater(), new PgAdminUrlUpdater(), new PipUrlUpdater(), new PycharmUrlUpdater(), | ||
| new PythonUrlUpdater(), new QuarkusUrlUpdater(), new RubyUrlUpdater(), new RustUrlUpdater(), new DockerRancherDesktopUrlUpdater(), new SonarUrlUpdater(), | ||
| new SquirrelSqlUrlUpdater(), new SoapUiUrlUpdater(), new TerraformUrlUpdater(), new TomcatUrlUpdater(), new UvUrlUpdater(), new VsCodeUrlUpdater(), new VsCodiumUrlUpdater()); | ||
| new JavaUrlUpdater(), new JenkinsUrlUpdater(), new JmcUrlUpdater(), new KotlincUrlUpdater(), new KotlincNativeUrlUpdater(), new LazyDockerUrlUpdater(), | ||
| new MvnUrlUpdater(), | ||
| new MvndUrlUpdater(), new NgUrlUpdater(), new NodeUrlUpdater(), new NpmUrlUpdater(), new OcUrlUpdater(), new PgAdminUrlUpdater(), new PipUrlUpdater(), | ||
| new PycharmUrlUpdater(), | ||
| new QuarkusUrlUpdater(), new RubyUrlUpdater(), new RustUrlUpdater(), new DockerRancherDesktopUrlUpdater(), new SonarUrlUpdater(), | ||
| new SquirrelSqlUrlUpdater(), new SoapUiUrlUpdater(), new TerraformUrlUpdater(), new TomcatUrlUpdater(), new UvUrlUpdater(), new VsCodeUrlUpdater(), | ||
| new VsCodiumUrlUpdater()); |
There was a problem hiding this comment.
Nothing technical wrong here, but how can we prevent these diff-wars and the ugly reformatting?
Is that cause by IntelliJ because my IntelliJ is not doing this?
I think it is stupid to break a line that is considered too long and then move a single updater out of the long CSV into its own line leaving a strange mess of long and short lines.
Either we have one url updater listed per line (what makes this very verbose and requires more vertical scrolling), or we have a commonly agreed number or chars per line and on reformatting each line is filled so that limit is not exceeded but the line gets as long as it is allowed to.
This PR fixes #2211
Implemented changes:
PythonUrlUpdaterand its supporting classesPythonFile,PythonJsonObjectandPythonRelease, together withPythonUrlUpdaterTestand its test resource.PythonUrlUpdaterimport and its entry in the updater list inUpdateManager.uv python list(PythonRepository) instead ofide-urls, so the Python URL metadata is no longer used for installing Python and does not need to be crawled anymore.dependencies.jsonandsecurity.jsoninide-urlsremain in use (findDependencies/findSecurity) and are untouched by this PR.ide-urlsis a separate PR (Delete python version metadata (devonfw/IDEasy#2211) ide-urls#45) in thedevonfw/ide-urlsrepository, which must only be merged after this PR, because the nightlyupdate-urlsworkflow would otherwise regenerate the deleted folders.Testing instructions
mvn clean test, all tests pass and the build is successful.UpdateManagerno longer referencesPythonUrlUpdaterand that the url-updater module still compiles and runs for the remaining tools.Update URLSworkflow no longer writes new Python versions intoide-urls; existing Python metadata stays untouched.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal