#2218: add missing 3rd party libs to LICENSE - #2231
Open
quando632 wants to merge 2 commits into
Open
Conversation
* add GraalVM SDK (nativeimage) as directly included component * add new inclusion type GUI and tag OpenJFX with it * update IntelliJ IDEA license and NOTE for the unified distribution since 2025.3 * sort table entries by inclusion (directly included, GUI, default setup, optional)
quando632
added
documentation
Collaborator
Coverage Report for CI Build 30448668581Coverage decreased (-0.02%) to 72.569%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
quando632
marked this pull request as ready for review
July 31, 2026 11:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2218
Implemented changes:
All four items of the issue are addressed in
documentation/LICENSE.adoc:GraalVM SDK (nativeimage)is now listed asDirectly includedunderUPL 1.0.The license was taken from the artifact POM of
org.graalvm.sdk:nativeimage(Universal Permissive License, Version 1.0) and verified against https://github.com/oracle/graal/blob/master/sdk/LICENSE.md.Directly included(14) →GUI(1) →Default Setup(5) →Optional(60).The existing relative order inside each group is preserved, so the diff stays minimal.
NOTEand theIntelliJ IDEArow claimedultimate editionresp.Apache 2.0, which has been wrong since IntelliJ IDEA 2025.3.JetBrains ships a single unified and proprietary distribution since then: core features are free of charge, the advanced features formerly known as
ultimaterequire a paid subscription, and only the open-source core is available as source under Apache 2.0.The row now links the JetBrains User Agreement and the Toolbox Subscription Agreement.
GUI: explained in the bullet list above the table and applied toOpenJFX, which was taggedOptionalbefore. The row was also made more precise by naming the actually used artifacts (javafx-controls,javafx-fxml).Our GUI dependencies were checked as requested: in
gui/pom.xmlOpenJFX is the only 3rd party runtime dependency. Everything else (testfx-core,testfx-junit5,openjfx-monocle,wiremock,junit-jupiter,assertj-core) isscope=testand therefore intentionally not listed; the remaining dependency iside-cli, i.e. IDEasy itself, which is already in the table.Also added the issue to
CHANGELOG.adoc.Testing instructions
This is a documentation-only change, no production code was touched.
documentation/LICENSE.adocand check the table: allDirectly includedrows come first, followed by the singleGUIrow, thenDefault Setupand finallyOptional.GraalVM SDK (nativeimage)row and that theGUIinclusion type is explained in the bullet list above the table.NOTEand theIntelliJ IDEArow no longer claimApache 2.0/ a separateultimateedition.mvn -o compilein thedocumentationfolder and check thattarget/generated-docs/license-rtf/LICENSE.xml(the DocBook source of the LICENSE RTF used by the MSI installer) is generated without errors and contains the new rows.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful — not run: no production code changed. Insteadmvn -o compilewas executed in thedocumentationmodule and the generated DocBook output was verified.#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)internalChecklist for tool commandlets
Not applicable — no new tool commandlet is added by this PR.
Open points for the reviewer
exec-maven-plugin:ide guistarts the GUI viamvn exec:exec, so Maven downloads this plugin on demand. It is not listed because the table does not list Maven plugins in general and Maven itself is already listed. Happy to add it underGUIif wanted.Pycharmhas the same problem as IntelliJ IDEA — PyCharm was unified with 2025.1, but the row still claimsApache 2.0. This is out of scope of Add missing 3rd party libs to LICENSE #2218, so it was left untouched. Should this become a follow-up issue or be fixed here as well?