#2180: Add *_PLUGINS_EXTRA variable to install extra IDE plugins per user - #2237
Open
Paras14 wants to merge 1 commit into
Open
#2180: Add *_PLUGINS_EXTRA variable to install extra IDE plugins per user#2237Paras14 wants to merge 1 commit into
Paras14 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2180
Implemented changes:
«TOOL»_PLUGINS_EXTRA(e.g.VSCODE_PLUGINS_EXTRA=eslint,cpp-tools,docker) allowing a user to activate additional plugins without modifying the shared project settings..propertiesextension, not to theidinside it. Unresolvable entries are skipped with a warning so a single stale entry cannot break the installation of the remaining plugins.PluginBasedCommandlet.getPlugins()rather than in a specific IDE commandlet, so it applies to Eclipse, VSCode and all IntelliJ-based IDEs. Plugins activated this way are reinstalled automatically when plugins are purged, unlike plugins installed manually in the IDE.documentation/plugin.adocanddocumentation/variables.adoc.«TOOL»_PLUGINS_EXTRAdoes not uninstall the plugin (the marker file survives). This is documented; resetting is done via--force-plugin-reinstall.Testing instructions
export IDE_ROOT=/your/ide/root && ./build-local-dev.sh(revert afterwards withideasy upgrade --mode=stable).ide vscodeand note a plugin logged asOmitting installation of inactive plugin icons (...), plus the plugin count in theInstall plugin ... (n/m)steps.$IDE_HOME/conf/ide.properties:VSCODE_PLUGINS_EXTRA=iconside vscodeagain. Expected:Start: Install plugin icons (n/m)withmone higher than in step 2, and the extension present under$IDE_HOME/plugins/vscode. The sharedsettings/directory is untouched (git statusinside it stays clean).idinstead of its filename, e.g.VSCODE_PLUGINS_EXTRA=vscode-icons-team.vscode-icons, and run again. Expected: a warning that the plugin is undefined, andiconsis not installed, the variable takes filenames only.VSCODE_PLUGINS_EXTRA=icons,typo-does-not-existand run again. Expected: one warning for the unknown entry,iconsinstalls anyway.INTELLIJ_PLUGINS_EXTRA=watchers(close IntelliJ first, IDEasy callsidea64.exeto install plugins).Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal