#218: add possibility to start a command in a new window with the process builder - #2239
Open
samuelkos17 wants to merge 4 commits into
Conversation
…the process builder
…nd-in-a-new-window-with-the-process-builder
Collaborator
Coverage Report for CI Build 30622595516Coverage decreased (-0.1%) to 72.527%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions72 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #218
Implemented changes:
ProcessMode#BACKGROUND_NEW_WINDOWmode that starts a command in a new terminal window while detaching it from the parent process.ProcessContextImpl:gnome-terminal,konsole,xfce4-terminal,tilix,alacritty,xterm,x-terminal-emulator) and uses the correct flag syntax for each, with adisownfallback when no terminal emulator is available.osascriptto launch a new Terminal.app or iTerm2 window via AppleScript.cmd.exe /c startto open a new CMD window.launchesNewWindow()method toProcessModeto check whether the mode should launch a process in a new window.isBackground()to include the newBACKGROUND_NEW_WINDOWmode.BackgroundNewWindowTest.java:disownfallback.Testing instructions
mvn clean test— all tests should pass, including the 10 new tests inBackgroundNewWindowTest.java.backgroundNewWindowShouldActuallyExecuteViaStartOnWindows— observe a new CMD window opening.backgroundNewWindowShouldActuallyExecuteViaOsascriptOnMac— observe a new Terminal.app (or iTerm2) window opening.backgroundNewWindowShouldActuallyExecuteOnLinux— observe a new terminal window opening (if a desktop environment is available), or the test passing via thedisownfallback in headless environments.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»:«brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal