Feat modern pipelines - #352
Draft
salfuen wants to merge 2 commits into
Draft
Conversation
…docker compose. *Need to validate apikeys / config on github
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
nabisobhi
reviewed
Aug 7, 2026
nabisobhi
left a comment
nabisobhi
left a comment
Contributor
There was a problem hiding this comment.
Really like this direction 🙌 Consolidating the Makefile + Azure pipeline into a single manual GitHub Actions release is a big win for readability and maintainability 💯
| permissions: | ||
| contents: write | ||
|
|
||
| jobs: |
Contributor
There was a problem hiding this comment.
One suggestion: I noticed the commit/tag/push currently happens before the build & test. So if the tests fail, we’ve already pushed a release: x.y.z commit and tag to the branch, but nothing has actually been published to NuGet. I’d suggest slightly changing the order:
- Update
src/Dafda/Dafda.csprojversion - Build → Test → Pack
- Commit + tag +
git push --follow-tags - NuGet push + GitHub Release
That way, we only push the tag once we have a green build. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves our release flow fully to GitHub Actions and removes the old Makefile-based process.
The release workflow now runs manually with a version input, updates the project version, builds, tests, packs, and publishes from the pipeline. It also supports a dry run mode so we can validate everything without pushing tags, packages, or GitHub releases.
I also cleaned up old pipeline files and updated the docs so build, release, and docs deploy commands no longer depend on make. (docs were moved to docker compose as well)