Always provision source controller IRSA role with the cluster and allow for pulls through pull through cache - #2396
Open
wcarlsen wants to merge 5 commits into
Conversation
…ow for pulls through pull through cache Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
|
I guess that triggered a bug in the provider 🙈 |
Contributor
Author
So on first run this fails, with an inconsistent plan from the provider, but it disappears on second run. |
…ent plans on first run and fails when replacements come from other resources. Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Contributor
Author
|
Added bug and blocked labels because there is a bug in the provider. |
avnes
previously approved these changes
Aug 6, 2026
avnes
left a comment
avnes
left a comment
Contributor
There was a problem hiding this comment.
LGTM. During my testings I did not experience any issues with this. But I was using the latest and greatest provider versions in my sandbox.
provider "registry.opentofu.org/fluxcd/flux" {
version = "1.9.3"
provider "registry.opentofu.org/hashicorp/tls" {
version = "4.3.0"
provider "registry.opentofu.org/integrations/github" {
version = "6.13.0"
…ource-ctrl-not-able-to-pull-from-cache
…ource-ctrl-not-able-to-pull-from-cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently source controller IRSA role is a shared role from shared-prod account, but since we implement allowed pulls if it is form an org account, we no longer need the shared account approach. So we let the clusters bring its own. We also solve a bug with the shared-prod IRSA role missing permissions to pull images from the pull through cache. Lastly this hopefully removes flaky diffs and random failures on fluxcd_bootstrap_git resource as described here https://dfds.slack.com/archives/CQD754GGL/p1782994535687589.
Issue ticket number and link
Checklist before requesting a review
test/integrationfolder to apply my changes in QA. Read the guide on adding environment variables in QAIs it a new release?
release:(major|minor|patch), following semantic versioning in this guide ornoreleaseif there is no changes to the Terraform code