Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
dfinity
/
icskills
Public
Notifications
You must be signed in to change notification settings
Fork
14
Star
36
Code
Issues
25
Pull requests
10
Discussions
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Discussions
Actions
Projects
Security and quality
Insights
feat: rewrite wallet-integration on @icp-sdk/signer
- #401
#401
Merged
raymondk
merged 27 commits into
main
dfinity/icskills:main
from
feat/wallet-integration-signer
dfinity/icskills:feat/wallet-integration-signer
Copy head branch name to clipboard
Sep 22, 2026
Conversation
Commits
27
(27)
Checks
Files changed
Merged
feat: rewrite wallet-integration on @icp-sdk/signer
#401
raymondk
merged 27 commits into
main
dfinity/icskills:main
from
feat/wallet-integration-signer
dfinity/icskills:feat/wallet-integration-signer
Copy head branch name to clipboard
Commits
Commits on Sep 22, 2026
feat(wallet-integration): rewrite on @icp-sdk/signer, integration only
Show description for cf43d77
marc0olo
committed
cf43d77
View commit details
Copy full SHA for cf43d77
Browse repository at this point
test(wallet-integration): replace the oisy-specific eval suite
Show description for 05a56e9
marc0olo
committed
05a56e9
View commit details
Copy full SHA for 05a56e9
Browse repository at this point
test(wallet-integration): make the delegation case test the library, not general knowledge
Show description for bb92419
marc0olo
committed
bb92419
View commit details
Copy full SHA for bb92419
Browse repository at this point
fix(wallet-integration): correct what --legacy-peer-deps does
Show description for 47c2eed
marc0olo
committed
47c2eed
View commit details
Copy full SHA for 47c2eed
Browse repository at this point
fix(wallet-integration): make every code block copy-pasteable
Show description for d496df9
marc0olo
committed
d496df9
View commit details
Copy full SHA for d496df9
Browse repository at this point
fix(wallet-integration): carry the account's subaccount through Path A
Show description for 008c796
marc0olo
committed
008c796
View commit details
Copy full SHA for 008c796
Browse repository at this point
fix(wallet-integration): persist the whole account across a reload
Show description for 4779f05
marc0olo
committed
4779f05
View commit details
Copy full SHA for 4779f05
Browse repository at this point
fix(wallet-integration): align the reload prose with the code
Show description for dad5151
marc0olo
committed
dad5151
View commit details
Copy full SHA for dad5151
Browse repository at this point
refactor(wallet-integration): request only the scopes a path uses, and
Show description for 69febb7
marc0olo
committed
69febb7
View commit details
Copy full SHA for 69febb7
Browse repository at this point
refactor(wallet-integration): one consistent rule for account identity
Show description for a311201
marc0olo
committed
a311201
View commit details
Copy full SHA for a311201
Browse repository at this point
fix(wallet-integration): SignerAgentError is not a transport failure
Show description for 6cdbe93
marc0olo
committed
6cdbe93
View commit details
Copy full SHA for 6cdbe93
Browse repository at this point
fix(wallet-integration): handle the error class transport failures actually arrive as
Show description for 1a3db4b
marc0olo
committed
1a3db4b
View commit details
Copy full SHA for 1a3db4b
Browse repository at this point
fix(wallet-integration): stop the prose contradicting the code it introduces
Show description for 5b5cf28
marc0olo
committed
5b5cf28
View commit details
Copy full SHA for 5b5cf28
Browse repository at this point
fix(wallet-integration): give every code block its own imports
Show description for 1a04ec9
marc0olo
committed
1a04ec9
View commit details
Copy full SHA for 1a04ec9
Browse repository at this point
refactor(wallet-integration): drop delegation, and fix three things the
Show description for 46dc7e2
marc0olo
committed
46dc7e2
View commit details
Copy full SHA for 46dc7e2
Browse repository at this point
fix(wallet-integration): stop indexing getAccounts() blindly
Show description for 0f85036
marc0olo
committed
0f85036
View commit details
Copy full SHA for 0f85036
Browse repository at this point
fix(wallet-integration): give an unnamed 3xxx feedback instead of silence
Show description for dd98b8f
marc0olo
committed
dd98b8f
View commit details
Copy full SHA for dd98b8f
Browse repository at this point
fix(wallet-integration): note that callCanister returns unverified output
Show description for 47e2029
marc0olo
committed
47e2029
View commit details
Copy full SHA for 47e2029
Browse repository at this point
fix(wallet-integration): omitting scopes does not set ask_on_use
Show description for 3271c1c
marc0olo
committed
3271c1c
View commit details
Copy full SHA for 3271c1c
Browse repository at this point
fix(wallet-integration): stop picking the first extension, and reconcile
Show description for 21c33e2
marc0olo
committed
21c33e2
View commit details
Copy full SHA for 21c33e2
Browse repository at this point
fix(wallet-integration): drop the ICRC-95 row it never delivers on
Show description for 8224459
marc0olo
committed
8224459
View commit details
Copy full SHA for 8224459
Browse repository at this point
fix(wallet-integration): apply sea-snake's review
Show description for f68374b
marc0olo
committed
f68374b
View commit details
Copy full SHA for f68374b
Browse repository at this point
refactor(wallet-integration): drive the redirect flow through SignerAgent
Show description for ca664ed
marc0olo
committed
ca664ed
View commit details
Copy full SHA for ca664ed
Browse repository at this point
fix(wallet-integration): the user-gesture rule is PostMessageTransport's, not every transport's
Show description for 2001547
marc0olo
committed
2001547
View commit details
Copy full SHA for 2001547
Browse repository at this point
test(wallet-integration): cover capability negotiation
Show description for 4012019
marc0olo
committed
4012019
View commit details
Copy full SHA for 4012019
Browse repository at this point
fix(wallet-integration): drop the "prompts once" count from Expected Behavior
Show description for d357e49
marc0olo
committed
d357e49
View commit details
Copy full SHA for d357e49
Browse repository at this point
fix(wallet-integration): the intro promised more portability than the skill delivers
Show description for bda91a6
marc0olo
committed
bda91a6
View commit details
Copy full SHA for bda91a6
Browse repository at this point
You can’t perform that action at this time.