Repository navigation
Preserve worksheet part identities when sorting - #640
Open
JimmyLiuJia wants to merge 1 commit into
Open
JimmyLiuJia wants to merge 1 commit into
JimmyLiuJia wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting worksheets after one or more sheets have been finished can attach a worksheet name to another sheet's cells, tab color and comments. A mix of finished and unfinished sheets can also create duplicate ZIP parts, producing an unreadable workbook.
Assign each worksheet a stable part index when it is created, and use its current tab position for the active tab and worksheet-scoped defined names. Add POI round-trip regressions for zero, one and all three sheets finished before sorting, checking sheet order and content, colors, comments, active sheet, repeating titles, autofilters and local named ranges.
Fixes #533.
Validation:
mvn -B -ntp clean verify jacoco:reporton JDK 11: 203 tests, zero failures, errors or skips.AI disclosure: OpenAI Codex assisted with the implementation and tests. The validation results above were obtained locally.