Conversation
…ch() Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…nature L13's event dispatcher calls wildcard listeners as (eventName, payload) instead of passing the event object directly. Accept both and unwrap payload[0] so whenX() handlers keep receiving the domain event object (previously ReflectionClass got the dotted event name and threw). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…unc_get_args Reverts the 2-param signature (broke every subclass override). Base stays handle($event); uses func_get_args() + a reusable unwrapEvent() helper so subclasses overriding handle() stay signature-compatible and can unwrap the L13 wildcard (eventName, payload) themselves. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the dicoding.com L42x→L13 migration. Fork
laravel/framework4.2.100 swapsilluminate/support(and the SCC-1 cluster) to v13, conflicting with commander'silluminate/support: ~4.0pin and its use of the removedDispatcher::fire().composer.json:illuminate/support~4.0→~4.0 || ^13.EventDispatcher:$this->event->fire(...)→->dispatch(...)(v13 removedfire()).The app pins
dev-compat/l13-support-13until this merges to master.