fix: regenerate dependencies-cargo.json for direct objc2 deps#166
Open
dormouse-bot wants to merge 1 commit into
Open
fix: regenerate dependencies-cargo.json for direct objc2 deps#166dormouse-bot wants to merge 1 commit into
dormouse-bot wants to merge 1 commit into
Conversation
The macOS dock-icon work made objc2/objc2-app-kit/objc2-foundation direct Cargo dependencies without regenerating the manifest, leaving them in the transitive section without declaredName. A clean generate-deps.js run moves them to the direct section. Closes #165 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
71d9fc1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://500c7d5b.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-regenerate-cargo-deps-ob.mouseterm.pages.dev |
This was referenced Jun 21, 2026
tend-mention: no-op session on bot's own APPROVED review of human PRs (upstream filing request)
#168
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates
website/src/data/dependencies-cargo.jsonso it matches a cleannode website/scripts/generate-deps.jsrun against the currentCargo.lock. This resolves the Dependency Supply Chain Check 1 failure reported in #165.What drifted
The macOS dock-icon work (
c2383c7"Improve macOS relaunch and dock icon", merged via #163) addedobjc2,objc2-app-kit, andobjc2-foundationas direct Cargo dependencies instandalone/src-tauri/Cargo.toml, but the committed dependency manifest was not regenerated afterward. The parallel regen PR (#160) landed on a branch that predated those direct deps, so the merge left the three crates listed in the transitive section without adeclaredNamefield.A clean regeneration moves them into the direct-dependency section and adds the
declaredNamefield — exactly the 45-line delta (24 insertions, 21 deletions) the security audit flagged. The npm and runtime manifests are unchanged.Verification
After committing this regeneration, re-running the generator produces no further diff.
On regression testing
This is a regenerated data file, not logic, so there's no unit test to add. The drift guard is the security audit itself (the
generate-deps.jsclean-checkout check that filed #165); it will pass once this lands. The underlying recurrence risk — aCargo.tomldependency change merging without a matching manifest regen — is a process gap the audit already covers.Closes #165.