docs: fix stale PendingShellOpts.command comment#167
Open
dormouse-bot wants to merge 1 commit into
Open
Conversation
The command is now typed into the spawned interactive shell at the prompt, not launched via shell -lc / cmd /c. Update the comment to match the typeCommandWhenPromptReady flow. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
2f9b0ef
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f8346897.mouseterm.pages.dev |
| Branch Preview URL: | https://docs-fix-pending-command-com.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a stale doc comment on
PendingShellOpts.commandleft behind by the recent command-launch refactor.The
dor split/dor ensure -- <cmd>path no longer launches the command viashell -lc <cmd>/cmd /c <cmd>(thecommandShellArgshelper was removed). It now spawns a plain interactive shell and types the command in once the pane reaches a prompt — seetypeCommandWhenPromptReady(getPlatform().writePty(id, \${command}\r`)), invoked fromgetOrCreateTerminalwhenshellOpts.command` is set.The comment still read "launched via
-lc//c", contradicting both the new behavior and the siblingrequireIntegrationdoc immediately below it (which already says the command is "typed"). Updated to describe the typed-into-shell flow.Comment-only change — no behavior change and nothing testable, so no regression test is included.