fix: point objcryst to the fixed spelling version - #30
Closed
stevenhua0320 wants to merge 1 commit into
Closed
Conversation
Contributor
|
This looks good to me but I am not expert. Also, do we have to support both spellings for a period in this layer, or we only need to deprecate at the user level? @vincefn ? |
Collaborator
|
@sbillinge the new code supports both spellings. This PR will be superseded by #31 (more complete) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge @vincefn ready to review. In this PR, we point
objcrystwith the latest version for corrected spelling ofORTHORHOMBIC. We do this because we need to fix thepyobjcrystmisspelling issue as referenced here:diffpy/pyobjcryst#97The next move is to release a new version of
libobjcrystif this PR could pass.