fix: Allow missing reference column mapping in issue checks

[gibahjoe]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

Allow column mapping when a check reports a critical missing reference issue, alongside the existing missing column and missing-field exceptions.

Users must still meet the existing mapping criteria, including having unassigned columns. Other critical external issues continue to block mapping. Missing references remain critical on the Check results page.

Related Tickets & Documents

• Closes Missing Reference blocks column mapping in Check #1294
• Related Jira ticket: DLSD-3702

QA Instructions, Screenshots, Recordings

Added/updated tests?

• Yes
• No, and this is why:
• I need help with writing tests

Regression tests cover critical missing reference issues, the spare-column requirement, and blocking by other critical external issues.

[optional] Are there any post deployment tasks we need to perform?

None.

[optional] Are there any dependencies on other PRs or Work?

None.

Summary by CodeRabbit

• Bug Fixes
  • Column mapping is no longer blocked by a missing reference issue alone. Mapping eligibility still depends on having a spare column and no other blocking critical issue.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6c971202-fca6-4e6f-91fb-e93431c7021c

📥 Commits

Reviewing files that changed from the base of the PR and between 7e1fac2 and fc79aa8.

📒 Files selected for processing (2)

• src/services/columnMappingDecider.js
• test/unit/statusController.test.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The column mapping decision now treats missing reference issues as non-blocking. Tests cover mapping eligibility when a spare column is available and when other blocking conditions are present.

Changes

Missing reference mapping

Layer / File(s)	Summary
Update mapping eligibility src/services/columnMappingDecider.js	The blocking-issue filter now exempts missing reference issues, alongside missing column and missing-field. The comment also identifies missing reference as fixable by column mapping.
Test mapping eligibility test/unit/statusController.test.js	Tests cover missing reference as a non-blocking issue. Additional cases check that mapping requires a spare column and is not offered when another critical external issue exists.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to fc79a

The change allows eligible users to try column mapping without bypassing the existing blockers. If the subsequent check still reports a critical missing-reference issue, it remains visible as an issue that must be fixed.

Pre-merge checks · 5

Passed checks (5 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly summarises the main change: allowing column mapping for critical missing reference issues.
Linked Issues check		The change for #1294 adds missing reference to the non-blocking issue types in hasBlockingNonColumnMappingTasks. The existing eligibility logic remains active. Tests cover an available spare colum…
Out of Scope Changes check		The changes are limited to the column-mapping decision rule, its explanatory comment, and regression tests. Each change supports #1294 or verifies the stated mapping conditions. No unrelated productio…
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the mapping gate,
A missing reference need not wait.
With spare columns in the row,
The mapping path can now show.
If other critical issues appear,
The rabbit knows the block is clear.}

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	77.35%	3122 / 4036
🔵	Statements	76.7%	3343 / 4358
🔵	Functions	72.27%	644 / 891
🔵	Branches	70.78%	1609 / 2273

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/services/columnMappingDecider.js	83.78%	75.36%	76.19%	88.46%	47, 55, 57, 59, 82, 115, 124

Generated in workflow #1674 for commit fc79aa8 by the Vitest Coverage Report Action