Skip to content

Remove duplication of digraph encoding information in the docs - #949

Merged
mtorpey merged 3 commits into
digraphs:mainfrom
William-Kenyon:fix-issue-861
Oct 14, 2026
Merged

mtorpey merged 3 commits into
digraphs:mainfrom
William-Kenyon:fix-issue-861

Conversation

@William-Kenyon

Copy link
Copy Markdown
Collaborator

Progress on #861, getting rid of the duplicated information about digraph encoding across DigraphFile, ReadDigraphs, and WriteDigraphs, by having them point to Encoding Formats. Encoding Formats was also missing file extensions and the pickling and plain text encodings.

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.47%. Comparing base (c4ced48) to head (996cbf4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
+ Coverage   97.46%   97.47%   +0.01%     
==========================================
  Files          51       51              
  Lines       21191    21301     +110     
  Branches      639      639              
==========================================
+ Hits        20653    20763     +110     
  Misses        473      473              
  Partials       65       65              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtorpey

mtorpey commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

This might sound fussy, but:

Could you please redo this with meaningful changes separated from whitespace changes? Currently it's quite hard to review.

Two separate commits would make this possible.

@james-d-mitchell james-d-mitchell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @William-Kenyon, this is a good set of changes to make. Please adjust according to my comments, and then I'll be happy to merge.

Comment thread doc/io.xml Outdated
Comment thread doc/io.xml Outdated
Comment thread doc/io.xml Outdated
Comment thread doc/io.xml Outdated
Comment thread doc/io.xml Outdated
Comment thread doc/io.xml Outdated
@Joseph-Edwards Joseph-Edwards added the VIP Pull requests done by participants of the VIP programme. label Oct 14, 2026
@mtorpey

mtorpey commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

I believe all James's comments have been resolved. Thanks for the good work, @William-Kenyon!

@mtorpey
mtorpey enabled auto-merge (squash) October 14, 2026 14:06
@mtorpey
mtorpey self-requested a review October 14, 2026 14:10
@mtorpey
mtorpey disabled auto-merge October 14, 2026 14:11
@mtorpey
mtorpey merged commit 8771b99 into digraphs:main Oct 14, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

VIP Pull requests done by participants of the VIP programme.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants