Repository navigation
Remove duplication of digraph encoding information in the docs - #949
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
==========================================
+ Coverage 97.46% 97.47% +0.01%
==========================================
Files 51 51
Lines 21191 21301 +110
Branches 639 639
==========================================
+ Hits 20653 20763 +110
Misses 473 473
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
This might sound fussy, but: Could you please redo this with meaningful changes separated from whitespace changes? Currently it's quite hard to review. Two separate commits would make this possible. |
William-Kenyon
force-pushed
the
fix-issue-861
branch
from
October 7, 2026 14:33
1e53cf4 to
f16564b
Compare
james-d-mitchell
previously requested changes
Oct 8, 2026
james-d-mitchell
left a comment
Member
There was a problem hiding this comment.
Thanks @William-Kenyon, this is a good set of changes to make. Please adjust according to my comments, and then I'll be happy to merge.
Collaborator
|
I believe all James's comments have been resolved. Thanks for the good work, @William-Kenyon! |
mtorpey
enabled auto-merge (squash)
October 14, 2026 14:06
mtorpey
self-requested a review
October 14, 2026 14:10
mtorpey
approved these changes
Oct 14, 2026
mtorpey
disabled auto-merge
October 14, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #861, getting rid of the duplicated information about digraph encoding across
DigraphFile,ReadDigraphs, andWriteDigraphs, by having them point toEncoding Formats.Encoding Formatswas also missing file extensions and the pickling and plain text encodings.