Skip to content

Use temporary files in manual examples - #953

Merged
james-d-mitchell merged 1 commit into
digraphs:mainfrom
Joseph-Edwards:examples-use-temporary-files
Oct 8, 2026
Merged

james-d-mitchell merged 1 commit into
digraphs:mainfrom
Joseph-Edwards:examples-use-temporary-files

Conversation

@Joseph-Edwards

Copy link
Copy Markdown
Collaborator

This PR updates some manual examples so that they no longer create files in the current directory or the digraphs directory. Instead, it creates temporary files with DirectoryTemporary.

Thank you to @William-Kenyon for highlighting this issue!

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.46%. Comparing base (c4ced48) to head (6d4a716).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #953   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          51       51           
  Lines       21191    21191           
  Branches      639      639           
=======================================
  Hits        20653    20653           
  Misses        473      473           
  Partials       65       65           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@james-d-mitchell
james-d-mitchell merged commit f4fc1ac into digraphs:main Oct 8, 2026
27 of 28 checks passed
@james-d-mitchell

Copy link
Copy Markdown
Member

Thanks @Joseph-Edwards

@Joseph-Edwards
Joseph-Edwards deleted the examples-use-temporary-files branch October 8, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants