Repository navigation
Add IsDigraphRotationSystem - #954
MeikeWeiss wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (84.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
==========================================
- Coverage 97.47% 97.45% -0.02%
==========================================
Files 51 51
Lines 21301 21316 +15
Branches 639 639
==========================================
+ Hits 20763 20774 +11
- Misses 473 477 +4
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
Thanks @MeikeWeiss, I thought I'd reviewed this already last week, but it looks like I forgot to hit the button. Here are some comments!
| <Description> | ||
| If <A>digraph</A> is a symmetric digraph and <A>list</A> is a rotation system of <A>digraph</A>, | ||
| then <C>IsDigraphRotationSystem</C> returns <C>true</C> if <A>list</A> is a rotation system for | ||
| <A>digraph</A>, and <C>false</C> otherwise. |
There was a problem hiding this comment.
This reads a little strangely "if ... list is a rotation system, then ... returns true, if list is a rotation system" probably the first "rotation system" should be "list"
| then <C>IsDigraphRotationSystem</C> returns <C>true</C> if <A>list</A> is a rotation system for | ||
| <A>digraph</A>, and <C>false</C> otherwise. | ||
| <A>list</A> is a rotation system of <A>digraph</A> if <A>list</A> has an entry for each vertex | ||
| <C>v</C> containing all neighbours of <C>v</C>. |
There was a problem hiding this comment.
Could you maybe add a little more detail here, I'm not sure I could identify when this function returns true and when it returns false from what you've written here.
| InstallMethod(IsDigraphRotationSystem, "for a digraph and a list", | ||
| [IsDigraph, IsList], | ||
| function(digraph, rotationSystem) | ||
|
|
| fi; | ||
|
|
||
| if Length(rotationSystem) <> DigraphNrVertices(digraph) then |
There was a problem hiding this comment.
| fi; | |
| if Length(rotationSystem) <> DigraphNrVertices(digraph) then | |
| elif Length(rotationSystem) <> DigraphNrVertices(digraph) then |
This branch has not been deployed
2 participants
See Issue #869