Repository navigation
Add DIGRAPHS_DeclareObsoleteSynonym - #955
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #955 +/- ##
=======================================
Coverage 97.47% 97.48%
=======================================
Files 51 53 +2
Lines 21301 21363 +62
Branches 639 639
=======================================
+ Hits 20763 20825 +62
Misses 473 473
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mtorpey
requested changes
Oct 14, 2026
mtorpey
self-requested a review
October 14, 2026 19:14
mtorpey
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #735, adding
DIGRAPHS_DeclareObsoleteSynonym, which behaves similarly toDeclareSynonym, but produces a warning each time the synonym is called, i.e."xxx" is obsolete and will be removed in a future version; use "yyy" instead,.Since the testing environment sets the warning level to 0, I had the tests temporarily set it to 1 and then restore the original value. I checked to see how other tests handled warnings, but could only find ones in
grahom.tst, which didn't require changing the warning level. This could be because their warning messages come fromhomos.c, so bypass GAP.This is progress towards #570, keeping
DigraphDijkstraas an obsolete synonym forDigraphShortestPaths.