Skip to content

Add DIGRAPHS_DeclareObsoleteSynonym - #955

Merged
mtorpey merged 5 commits into
digraphs:mainfrom
William-Kenyon:fix-issue-735
Oct 14, 2026
Merged

mtorpey merged 5 commits into
digraphs:mainfrom
William-Kenyon:fix-issue-735

Conversation

@William-Kenyon

Copy link
Copy Markdown
Collaborator

Fixes #735, adding DIGRAPHS_DeclareObsoleteSynonym, which behaves similarly to DeclareSynonym, but produces a warning each time the synonym is called, i.e. "xxx" is obsolete and will be removed in a future version; use "yyy" instead,.

Since the testing environment sets the warning level to 0, I had the tests temporarily set it to 1 and then restore the original value. I checked to see how other tests handled warnings, but could only find ones in grahom.tst, which didn't require changing the warning level. This could be because their warning messages come from homos.c, so bypass GAP.

This is progress towards #570, keeping DigraphDijkstra as an obsolete synonym for DigraphShortestPaths.

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (f4fc1ac) to head (8b25cee).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #955   +/-   ##
=======================================
  Coverage   97.47%   97.48%           
=======================================
  Files          51       53    +2     
  Lines       21301    21363   +62     
  Branches      639      639           
=======================================
+ Hits        20763    20825   +62     
  Misses        473      473           
  Partials       65       65           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread gap/obsolete.gi Outdated
@Joseph-Edwards Joseph-Edwards added the VIP Pull requests done by participants of the VIP programme. label Oct 14, 2026
@mtorpey
mtorpey self-requested a review October 14, 2026 19:14
@mtorpey
mtorpey merged commit 7c00ce7 into digraphs:main Oct 14, 2026
28 checks passed
@William-Kenyon
William-Kenyon deleted the fix-issue-735 branch October 14, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

VIP Pull requests done by participants of the VIP programme.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System for marking obsolete methods

3 participants