Repository navigation
Conversation
…aphs and LAD format
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (9.52%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
==========================================
- Coverage 97.45% 97.30% -0.15%
==========================================
Files 50 51 +1
Lines 21189 21391 +202
Branches 639 639
==========================================
+ Hits 20649 20815 +166
- Misses 475 511 +36
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
james-d-mitchell
left a comment
There was a problem hiding this comment.
Thanks for the contribution @RagdAhmed ! The failing CI is unrelated to the changes in this PR (some internet issue). There are no tests, or documentation, both of which are required before we review this properly, can you please add tests and doc?
Also I wonder if it would be appropriate to add detection of .lad to the machinery in ReadDigraphs and WriteDigraphs so that it's possible to "auto" detect this format? If anything is unclear, please ask at the next meeting!
No description provided.