Skip to content

LAD serialiser/Deserialiser - #956

Open
RagdAhmed wants to merge 2 commits into
digraphs:mainfrom
RagdAhmed:add-lad-format
Open

RagdAhmed wants to merge 2 commits into
digraphs:mainfrom
RagdAhmed:add-lad-format

Conversation

@RagdAhmed

Copy link
Copy Markdown

No description provided.

@Joseph-Edwards Joseph-Edwards added the VIP Pull requests done by participants of the VIP programme. label Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 9.52381% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.30%. Comparing base (8d49e9a) to head (263a3ce).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
gap/io.gi 5.00% 38 Missing ⚠️

❌ Your patch check has failed because the patch coverage (9.52%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   97.45%   97.30%   -0.15%     
==========================================
  Files          50       51       +1     
  Lines       21189    21391     +202     
  Branches      639      639              
==========================================
+ Hits        20649    20815     +166     
- Misses        475      511      +36     
  Partials       65       65              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@james-d-mitchell james-d-mitchell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @RagdAhmed ! The failing CI is unrelated to the changes in this PR (some internet issue). There are no tests, or documentation, both of which are required before we review this properly, can you please add tests and doc?

Also I wonder if it would be appropriate to add detection of .lad to the machinery in ReadDigraphs and WriteDigraphs so that it's possible to "auto" detect this format? If anything is unclear, please ask at the next meeting!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

VIP Pull requests done by participants of the VIP programme.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants