Repository navigation
Rename DigraphDijkstra to DigraphShortestPaths - #958
William-Kenyon wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 53 53
Lines 21363 21364 +1
Branches 639 639
=======================================
+ Hits 20825 20826 +1
Misses 473 473
Partials 65 65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
james-d-mitchell
left a comment
There was a problem hiding this comment.
@mtorpey can you please have a look at this.
My initial reaction is that I'm not sure this addresses #570. In particular, if there's duplicate code between DigraphDijkstra and DigraphShortestPath, then this PR does not remove it. Also if we merge this PR, there will be two functions DigraphShortestPath and DigraphShortestPaths which return two rather different outputs. Also it's not completely clear to me that DigraphShortestPaths is an entirely accurate name, given that it does not return all shortest paths from source to target as the name suggests.
Maybe I'm missing something essential, @William-Kenyon if there's context or rationale behind these changes that I'm missing, then please do let me know!
|
@james-d-mitchell My renaming follows existing convention: we already have The current use of the As for duplication, |
Fixes #570, renaming
DigraphDijkstratoDigraphShortestPaths, using the newDIGRAPHS_DeclareObsoleteSynonym.