Repository navigation
Deserialize custom workspaces using a placeholder - #450
Merged
Merged
Conversation
Jondolf
changed the title
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses dimforge/rapier#999 (review).
Currently, deserializing a custom workspace returns an error, as the type is unknown to Parry and the data was lost during serialization. When deserializing the physics world in Rapier, this failure propagates up and fails the whole snapshot.
This PR makes deserializing an unknown (custom) workspace return an
UnknownContactManifoldsWorkspaceinstead of an error. This dummy value can be replaced with the actual workspace type at the next execution of the relevant algorithm.