Repository navigation
Conversation
Signed-off-by: Srinivasa Dinakar Jainti <dinakarjs@gmail.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
github-actions
Bot
added
the
needs-review:MEDIUM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review follow-up for upstream cMCP agentrust-io#744 at exact head
0581739fcf02649ad6b21cf298a74f76a1520fce.Its synthetic forwarding test initializes
forwarded=0and never observes a forwarding seam on the refusal branch. This one-file proposal invokes the production Clickstartentry point, wraps the realbuild_serverand CMCPProxy constructor, and observes an AsyncMock at_forward_to_upstream. The valid twin composes one actual server/proxy and forwards one synthetic call. Eleven refusal cases observe zero server builds, zero proxy constructions and zero forwarding awaits: signed seal mismatch/missing, policy mismatch, subject mismatch, expiry, empty trust, missing/duplicate/unknown requirements, signature tampering and changed catalog server identity.The original fixture module is reused as a pytest plugin; no production source is changed.
uvicorn.runis replaced only in tests to avoid opening a listener, and the upstream is mocked. These are software-only composition/forwarding controls, not live provider, hardware, deployment completeness or conformance evidence.Local Python 3.12.14, installed hash-locked cMCP dependencies (Agent Manifest 0.15.0; cbor2 6.1.4): original PR unit/integration suite 2353 passed / 6 skipped; focused original module 10 passed; new CLI controls 12 passed; combined unit/integration including the addition 2365 passed / 6 skipped. Ruff passes. Initial full-suite failures came from inherited SOCKS proxy variables and HTTPX's absent optional socksio; the successful run unset those environment variables without changing dependency declarations. No live workflow was dispatched or runtime bypass committed.
This draft is an isolated contributor-fork diff for the original author to integrate or adapt. It does not update their branch, approve/merge agentrust-io#744 or extend the experimental profile's normative scope.
Signed-off-by: Srinivasa Dinakar Jainti dinakarjs@gmail.com