Repository navigation
feat: per-package requireBumpFile for bumpy check - #168
Conversation
|
The changes in this PR will be included in the next version bump.
|
There was a problem hiding this comment.
Important
Two valid control-flow paths do not preserve the new explicit bump-file requirement and should be corrected before merging.
Reviewed changes Reviewed the per-package configuration contract, local and CI coverage detection, generated PR guidance, schema and documentation updates, and the new integration suite.
- Configuration surface Adds
requireBumpFileto package config types, schema, package globs, documentation, and add-change guidance. - Local enforcement Makes
bumpy checkreject opted-in changed packages unless a branch bump file explicitly lists them, includingnoneentries. - CI enforcement and comments Extends
bumpy ci check, release-plan comments, and empty-file comments with required-package failures and--no-failwarnings. - Verification The focused 13-test suite, package type check, and repository formatting check pass; the findings concern valid edge paths not covered by the added tests.
gpt-5.6-sol | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the fixes added since the prior Pullfrog review.
- Fixed-group enforcement Derived required-package misses from changed packages versus explicit bump-file entries, so propagated fixed-group coverage cannot satisfy
requireBumpFile. - Zero-file CI guidance Added required-package detection and explicit
patch/noneremediation when a branch has no bump files, including accurate--no-failcomment wording. - Regression coverage Added tests for the fixed-group edge case and zero-bump-file PR comments; the focused feature suite, existing comment suite, type check, and formatting check pass.
gpt-5.6-sol | 𝕏
af477a5 to
eaba8e6
Compare



Adds a per-package
requireBumpFile: trueoption (package.json"bumpy"or root.bumpy/_config.jsonpackages, name or glob). When such a package changed on the branch,bumpy checkandbumpy ci checkfail unless a bump file lists it — regardless of other bump files on the branch. Global--strictis too broad for monorepos where most packages are fine with the lenient default.bumpy add --empty) does not satisfy it; listing the package with typenonedoes.ci check— the package must be listed explicitly, matchingbumpy check.bumpy add --packages "<name>:patch"plus the:nonealternative.--no-fail); the empty-bump-file comment no longer says "no version bump is needed" in that case.--no-failrespected.Motivating case: varlock's independently versioned
@varlock/native-helper-*packages, which only release when bumped — a PR that changes a helper while bumpingvarlockmust not silently skip the helper bump.Schema, types, docs (
configuration.md,cli.md), and the add-change skill updated. New integration tests covercheckandci check: required uncovered with another bump file → fail; covered bynone→ pass; empty bump file → still fail; non-required stays lenient;--no-fail→ pass.