Skip to content

feat: per-package requireBumpFile for bumpy check - #168

Merged
theoephraim merged 2 commits into
mainfrom
claude/per-package-strict-check-e9bde6
Oct 29, 2026
Merged

theoephraim merged 2 commits into
mainfrom
claude/per-package-strict-check-e9bde6

Conversation

@theoephraim

Copy link
Copy Markdown
Member

Adds a per-package requireBumpFile: true option (package.json "bumpy" or root .bumpy/_config.json packages, name or glob). When such a package changed on the branch, bumpy check and bumpy ci check fail unless a bump file lists it — regardless of other bump files on the branch. Global --strict is too broad for monorepos where most packages are fine with the lenient default.

  • An empty bump file (bumpy add --empty) does not satisfy it; listing the package with type none does.
  • Propagated bumps (cascade / fixed group / dependency) don't count in ci check — the package must be listed explicitly, matching bumpy check.
  • Errors name the package and print bumpy add --packages "<name>:patch" plus the :none alternative.
  • PR comment: release-plan and empty-bump-file comments get a blocking "Missing required bump files" section (warning style under --no-fail); the empty-bump-file comment no longer says "no version bump is needed" in that case.
  • --no-fail respected.

Motivating case: varlock's independently versioned @varlock/native-helper-* packages, which only release when bumped — a PR that changes a helper while bumping varlock must not silently skip the helper bump.

Schema, types, docs (configuration.md, cli.md), and the add-change skill updated. New integration tests cover check and ci check: required uncovered with another bump file → fail; covered by none → pass; empty bump file → still fail; non-required stays lenient; --no-fail → pass.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

bumpy-frog

The changes in this PR will be included in the next version bump.

minor Minor releases

  • @varlock/bumpy 1.18.1 → 1.19.0

Bump files in this PR

Click here if you want to add another bump file to this PR


This comment is maintained by bumpy.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Two valid control-flow paths do not preserve the new explicit bump-file requirement and should be corrected before merging.

Reviewed changes Reviewed the per-package configuration contract, local and CI coverage detection, generated PR guidance, schema and documentation updates, and the new integration suite.

  • Configuration surface Adds requireBumpFile to package config types, schema, package globs, documentation, and add-change guidance.
  • Local enforcement Makes bumpy check reject opted-in changed packages unless a branch bump file explicitly lists them, including none entries.
  • CI enforcement and comments Extends bumpy ci check, release-plan comments, and empty-file comments with required-package failures and --no-fail warnings.
  • Verification The focused 13-test suite, package type check, and repository formatting check pass; the findings concern valid edge paths not covered by the added tests.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using gpt-5.6-sol | 𝕏

Comment thread packages/bumpy/src/commands/check.ts Resolved
Comment thread packages/bumpy/src/commands/ci.ts Resolved

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes Reviewed the fixes added since the prior Pullfrog review.

  • Fixed-group enforcement Derived required-package misses from changed packages versus explicit bump-file entries, so propagated fixed-group coverage cannot satisfy requireBumpFile.
  • Zero-file CI guidance Added required-package detection and explicit patch / none remediation when a branch has no bump files, including accurate --no-fail comment wording.
  • Regression coverage Added tests for the fixed-group edge case and zero-bump-file PR comments; the focused feature suite, existing comment suite, type check, and formatting check pass.

Pullfrog  | View workflow run | Using gpt-5.6-sol | 𝕏

@theoephraim
theoephraim force-pushed the claude/per-package-strict-check-e9bde6 branch from af477a5 to eaba8e6 Compare October 29, 2026 04:27
@theoephraim
theoephraim merged commit 9d2b541 into main Oct 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant