Repository navigation
A decorator that fails to resolve reports its error twice - #1285
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed the decorator failure caching fix and its regression coverage.
- Failure caching: Failed decorator value resolution retains its original error without rerunning on subsequent calls.
- Regression coverage: Tests that an unset current environment produces one
forEnv()error; includes avarlockpatch release entry.
All 1,201 env-graph tests passed, including the new regression.
gpt-6.1-sol | 𝕏
DecoratorInstance.resolve() did not remember a failed attempt, so the next call ran the resolver again and recorded the same error again. resolveDecorators and processRequired both resolve @required, so an error from its value showed up twice on the item.
theoephraim
force-pushed
the
fix-duplicate-decorator-errors
branch
from
November 13, 2026 00:47
00b950e to
7cb3f6a
Compare
varlock
@varlock/astro-integration
@varlock/cloudflare-integration
@varlock/nextjs-integration
@varlock/nuxt-integration
@varlock/vite-integration
@varlock/1password-plugin
@varlock/aws-secrets-plugin
@varlock/azure-key-vault-plugin
@varlock/bitwarden-plugin
@varlock/keepass-plugin
@varlock/pass-plugin
@varlock/proton-pass-plugin
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

cause:
fix: remember that the attempt failed and return early on the next call.
forEnv()is only the easiest way to trigger it. any decorator value that throws is affected.test:
decorator-error-once.test.ts, fails on main.