Repository navigation
A cycle next to any other schema error ends the load with no explanation - #1286
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed cycle detection ordering, error propagation, and the regression test; all 129 focused tests passed.
- Cycle diagnostics: Marks dependency cycles before returning for other schema errors, preventing resolution from waiting indefinitely.
- Regression coverage and release note: Tests a self-reference alongside a missing reference and records the fix for a patch release.
gpt-6.1-sol | 𝕏
finishLoad returned before the cycle check when any item had a schema error. An item on a cycle was then left unmarked, waited on itself when values were resolved, and the CLI gave up with "varlock stopped before the command finished" instead of showing either error.
theoephraim
force-pushed
the
fix-cycle-with-schema-error
branch
from
November 13, 2026 00:47
183e529 to
0dee8a8
Compare
varlock
@varlock/astro-integration
@varlock/cloudflare-integration
@varlock/nextjs-integration
@varlock/nuxt-integration
@varlock/vite-integration
@varlock/1password-plugin
@varlock/aws-secrets-plugin
@varlock/azure-key-vault-plugin
@varlock/bitwarden-plugin
@varlock/keepass-plugin
@varlock/pass-plugin
@varlock/proton-pass-plugin
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

each line alone gives its proper error on main. together they give neither.
cause:
fix: mark cycles before that early return.
context: found by a fuzzer that compares varlock against a small reference implementation of the schema language, part of the same exploration as #469.
test:
cycle-with-schema-error.test.ts. on main it never finishes.