Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed the literal forEnv() argument checks, their graph lifecycle integration, and the shared suggestion helper.
- Enum diagnostics: Warns about impossible literal arguments while preserving warning-only behavior and parent-versus-child environment selection.
- Shared suggestions: Extracts edit-distance matching, preserves CLI dash normalization, and bounds suggestion input lengths.
- Coverage and docs: Adds regression tests and documents when arguments are checked. All 194 focused and adjacent tests passed.
gpt-6.1-sol | 𝕏
A static forEnv() arg that is not a member of the @currentEnv item's enum can never match, so @required=forEnv(prodution) silently never requires anything. It is now a warning with the closest enum value as a hint. Only checked when the item is a plain enum with literal members.
theoephraim
force-pushed
the
warn-forenv-unknown-env
branch
from
November 13, 2026 00:47
65cc6d7 to
14573a2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

only checked when the
@currentEnvitem is a plainenum(...)with literal members and the arg is written out literally.forEnv($OTHER)and computed enums are left alone.it's a warning, not an error, so a schema with a stale env name still loads.
the "did you mean" uses the same edit-distance helper the CLI already had for mistyped flags, moved to
lib/suggest-closest.ts.test:
forenv-env-names.test.ts.