Repository navigation
Allow dot-separated paths into nested JSON in awsSecret and awsParam - #1291
Merged
theoephraim merged 4 commits intoNov 12, 2026
Merged
Conversation
An exact top-level key still wins, so existing keys with dots keep working. Object and array values are returned as JSON text instead of [object Object].
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed nested JSON extraction for both AWS resolvers, including cached and uncached call paths.
- JSON lookup: Adds dot-separated traversal with exact top-level key precedence and JSON serialization for object and array values.
- Resolver integration: Shares lookup logic between
awsSecret()andawsParam()while retaining service-specific errors. - Tests and documentation: Adds 11 passing lookup tests and documents the behavior; plugin typechecking also passes.
gpt-6.1-sol | 𝕏
Contributor
There was a problem hiding this comment.
ℹ️ No runtime concerns found. Two minor documentation corrections are noted inline.
Reviewed changes: Reviewed the documentation added since the previous Pullfrog review.
- Added a worked example: Documented nested database settings and feature flags with corresponding typed
.env.schemaentries. - Explained lookup behavior: Added guidance on named keys, JSON serialization, missing-path hints, and key precedence.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

awsSecret()andawsParam()can now read nested JSON with a dot-separated key:Secrets Manager secrets are usually flat key-value JSON, and that stays the default. Nested objects are useful when one secret describes one thing with several parts, such as a database connection or a set of feature flags. Before this change, the plugin could only read top-level keys, so nested values had to be flattened or read in application code.
An exact top-level key with the same name still wins, so existing keys that contain dots keep working. Object and array values come back as JSON text instead of
[object Object].The lookup is in
src/json-key.tsso it can be unit tested. Error messages and tips are unchanged, except that a missing nested key lists the keys at the level where the path stopped.The website docs include a worked example: a secret with nested
dbandfeatureFlagssections and the schema that reads its values.