Repository navigation
Add timeZone data type; rename simple-object to simpleObject - #1300
Conversation
github-actions
Bot
added
maintainer
core:website
core:varlock
core:vscode-plugin
labels
|
The changes in this PR will be included in the next version bump.
|
📦 Bundle size
dist/ only; native binaries are versioned separately and not counted here. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Wrongly cased legacy time zone aliases still pass validation on Node, despite the case-sensitive contract.
Reviewed changes: Reviewed the new time zone validator, the backward-compatible object type rename, and their editor, documentation, and test updates.
- Time zone validation: Adds
timeZoneusing the runtime database, with offset rejection and casing suggestions. - Object type rename: Introduces
simpleObjectwhile retainingsimple-objectwith deprecation warnings. - User-facing support: Updates reference documentation, VS Code completions and diagnostics, and serialization and code-generation fixtures.
gpt-6.1-sol ｜ 𝕏
There was a problem hiding this comment.
ℹ️ No new issues found in the icon-bundling changes. Existing validation feedback remains unresolved, so approval is still withheld.
Reviewed changes: Reviewed the changes since c6cbeb4.
- Bundled the timeZone icon: Added the SVG and generated icon-map entry so TypeScript generation can embed it without a network request.
- Updated icon attribution: Added the icon to the license inventory; verified the bundled entry matches the source SVG.
gpt-6.1-sol ｜ 𝕏
varlock
@varlock/astro-integration
@varlock/cloudflare-integration
@varlock/nextjs-integration
@varlock/nuxt-integration
@varlock/vite-integration
@varlock/1password-plugin
@varlock/aws-secrets-plugin
@varlock/azure-key-vault-plugin
@varlock/bitwarden-plugin
@varlock/keepass-plugin
@varlock/pass-plugin
@varlock/proton-pass-plugin
commit: |
There was a problem hiding this comment.
ℹ️ No new distinct issues found. Approval remains withheld because the existing alias-casing concern is only partially addressed: Node still accepts
Us/Eastern,US/EASTERN, andEtc/Utc.
Reviewed changes: Reviewed the validator and editor changes since 9580529.
- Added alias checks: Rejected lowercase segment starts for legacy aliases and added runtime regressions while preserving correctly cased aliases.
- Mirrored editor validation: Added runtime-equivalent casing diagnostics and regression coverage, resolving the previous editor feedback.
gpt-6.1-sol ｜ 𝕏
There was a problem hiding this comment.
Important
Zero-offset aliases still bypass the new standard-name-only validation policy.
Reviewed changes: Reviewed the validation changes since d94e84f.
- Restricted accepted spellings: Replaced alias-casing heuristics with runtime standard names, current IANA replacements for frozen CLDR names, and fixed-offset exceptions.
- Aligned editor validation: Extracted mirrored runtime and editor helpers and updated alias rejection and suggestion tests.
- Updated the documented contract: Documented legacy alias rejection and
UTCas the accepted zero-offset spelling.
gpt-6.1-sol ｜ 𝕏
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
varlock-website | fa065ad | Commit Preview URL Branch Preview URL |
Nov 13 2026, 12:53 AM |
…ts still checked)
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: Reviewed the time zone validation changes since 24df6e8, including the explicitly accepted alias-casing limitation on Node.
- Restored runtime-known aliases: Removed the standard-name inventory while retaining offset rejection and best-effort casing checks.
- Aligned editor validation: Mirrored runtime acceptance and updated regression tests; data-type tests passed on Node and Bun, and editor diagnostics tests passed.
- Updated the documented contract: Removed the one-spelling restriction to match restored alias support.
gpt-6.1-sol ｜ 𝕏
Closes #1100.
@type=timeZonethat validates IANA time zone names using the runtime'sIntltz database, so no zone list is bundled.US/Eastern,Asia/Calcutta,Etc/UTC). Engines disagree slightly on obscure aliases (e.g. Bun rejectsEST5EDT); we accept that rather than maintain our own list.+05:00) are rejected, since engines accept them but they are not IANA names.europe/madrid) is rejected with a suggestion. Engines match case-insensitively, but consumers likeTZon Linux do not. Miscased aliases that keep a leading capital (Us/Eastern) can still slip through on Node, which does not expose alias casing.simple-objecttosimpleObjectso all built-in type names are camelCase.simple-objectstill works with a deprecation warning; it will be removed in the next major.