fix(down): remove dangling images left behind by local builds - #14154
Open
htoyoda18 wants to merge 1 commit into
Open
fix(down): remove dangling images left behind by local builds#14154htoyoda18 wants to merge 1 commit into
htoyoda18 wants to merge 1 commit into
Conversation
Signed-off-by: hiroto.toyoda <hiroto.toyoda@dena.com>
htoyoda18
force-pushed
the
fix/down-prune-dangling-images
branch
from
August 30, 2026 19:26
b73e1c9 to
caeabae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
down --rminever cleaned up dangling (untagged) images left behind by earlier local builds of the project — historically skipped because printing raw image IDs in CLI progress output is confusing on its own.Added
ImagePruner.danglingLocalImagesto find them (same project-label +dangling=truequery already used bywatch --prune's dangling cleanup), and report their removal as a single grouped "Dangling images" operation instead of one row per image ID. Individual removal failures are tolerated (debug-logged) so a stale/in-use image doesn't abort the rest ofdown, matching thewatch --pruneprecedent.Both the query shape and the "tolerate individual failures, debug-log only" behavior are modeled directly on
pruneDanglingImagesOnRebuildinpkg/compose/watch.go, whose dangling-image matching was itself just fixed in #14012.Added unit tests for
ImagePruner.danglingLocalImagesandpruneDanglingProjectImages(grouped single event pair regardless of image count, failure tolerance, and no-op when nothing to prune).Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
