Repository navigation
test: shrink GitHub archive file-count fixtures - #4670
Merged
Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
dgageot
marked this pull request as ready for review
October 20, 2026 10:17
trungutt
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the 4,097-entry file-count overflow fixture with two small, real tar/gzip extraction cases: three files accepted and a fourth rejected.
Implements the archive-test finding from #4664; separate from #4669.
Hosted measurements
CI run passed, including Windows, Linux, lint, cross-compilation, gate, and CodeQL.
TestGitHubArchiveLimits/file_countnow takes 0.01s on Windows and 0.01s on Linux. Earlier normal Windows CI measurements were around 42s for the 4,096 real file writes/deletions. These are test timings, not a claim about equivalent whole-job savings.Validation
task buildtask testtask lintgo test -count=1 -json ./pkg/skills -run '^TestGitHub'go test -race -count=1 ./pkg/skillsCryptographically signed and DCO-signed commit.