Repository navigation
test(keychain): cover context-bound OpenSession over an in-process D-Bus link - #668
Merged
Merged
Conversation
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Benehiko
marked this pull request as ready for review
October 15, 2026 12:26
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
This incremental review covers commits since 32f63cd5a379.
Assessment: 🟡 NEEDS ATTENTION
The drain-window mechanism correctly defers connection teardown until pending session workers finish, and the goroutine-leak and unbuffered-channel fixes are sound. One concurrency gap was found in the new drain logic: the drainTimer.Stop() return value is not checked, so both the timer goroutine and finishSessionRequest can independently close the connection. A secondary low-severity note covers the timer racing with an in-flight CloseSession call.
joe0BAB
reviewed
Oct 15, 2026
joe0BAB
reviewed
Oct 15, 2026
Benehiko
force-pushed
the
fix/keychain-session-timeout
branch
from
October 15, 2026 13:41
a1f2272 to
bb2692f
Compare
Benehiko
changed the title
joe0BAB
force-pushed
the
refactor/opensession-ctx
branch
from
October 15, 2026 14:00
abcce0c to
51a3cc4
Compare
…Bus link Exercise OpenSession against an exported fake Secret Service on a net.Pipe peer connection: DH-AES negotiation, the session-open timeout surfacing context.DeadlineExceeded, a late success or error reply after a timeout not reaching the next call, Close disconnecting immediately after a timeout, caller cancellation, and an already-cancelled context never reaching the backend. Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
Benehiko
force-pushed
the
fix/keychain-session-timeout
branch
from
October 15, 2026 14:29
bb2692f to
07469b0
Compare
joe0BAB
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #697; retarget to main once it merges.
#697 replaces the OpenSession goroutine and select with a single CallWithContext, which removes the leak this PR originally fixed with a pending-session drain in Close. That drain logic is dropped here. What remains is the in-process D-Bus fixture (a fake Secret Service exported over a net.Pipe peer connection) and tests for the new behavior:
The previous head is kept locally as backup/keychain-session-timeout-a1f2272.