Repository navigation
fix(pass): reject empty secrets before authorizing --force - #695
Merged
Merged
Conversation
The store now returns store.ErrEmptySecret from Save and Upsert on every platform (#694). With --force, set asked the engine to authorize the overwrite before the store could reject the value, so the user approved an overwrite that then failed. Check the value right after reading it instead, before any engine round-trip. Move the value switch into a readSecret helper to keep SetCommand under the gocyclo limit. Signed-off-by: Johannes Großmann <grossmann.johannes@t-online.de>
joe0BAB
force-pushed
the
fix/pass-set-empty-secret
branch
from
October 14, 2026 11:33
51c6129 to
48a7256
Compare
joe0BAB
marked this pull request as ready for review
October 14, 2026 11:35
Benehiko
approved these changes
Oct 14, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The store now returns store.ErrEmptySecret from Save and Upsert on every platform (#694). With --force, set asked the engine to authorize the overwrite before the store could reject the value, so the user approved an overwrite that then failed. Check the value right after reading it instead, before any engine round-trip.
Move the value switch into a readSecret helper to keep SetCommand under the gocyclo limit.