Skip to content

refactor(store): move ErrEmptySecret to x/secrets #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joe0BAB merged 1 commit into from
Oct 14, 2026
Merged

refactor(store): move ErrEmptySecret to x/secrets #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions store/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@
package store

import (
"errors"

"github.com/docker/secrets-engine/x/secrets"
)

var ErrCredentialNotFound = secrets.ErrNotFound

// ErrEmptySecret is returned by Save and Upsert when the secret's value is
// empty.
var ErrEmptySecret = errors.New("secret value must not be empty")
var ErrEmptySecret = secrets.ErrEmptySecret
1 change: 1 addition & 0 deletions x/secrets/secrets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
var (
ErrNotFound = errors.New("secret not found")
ErrAccessDenied = errors.New("access denied") // nuh, uh, uh!
ErrEmptySecret = errors.New("secret value must not be empty")
)

type Envelope struct {
Expand Down
Loading