Add $dbStats tests#622
Conversation
…on type validation and target collections primarily) Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
…ding field to diagnostic_test_case Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage); effort from diff stats (691+1 LOC, 8 files); LLM: Adds new test coverage for the $dbStats diagnostic command operator, expanding compatibility test suite as part of tracked issues. If a label is wrong, remove it manually and ping |
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
Signed-off-by: PatersonProjects <keldonhoff@gmail.com>
| expected_scaled = unscaled.get("dataSize") / 1024 | ||
| actual_scaled = scaled.get("dataSize") | ||
| assertSuccess( | ||
| actual_scaled == pytest.approx(expected_scaled, abs=1.0), |
There was a problem hiding this comment.
This field should be result from execution, why have == in it?
There was a problem hiding this comment.
My recollection is this was a workaround to allow the pytest.approx comparison of the scaled an unscaled values, rather than a plain assert or a potentially flaky exact comparison, could be replaced with a new check and an assertProperties instead to avoid the misuse of assertSuccess?
3 participants
This PR adds the tests for the dbStats diagnostic command operator.
Ref: Issue #43, #437