Skip to content

Add $floor arithmetic expression tests#664

Open
danielfrankcom wants to merge 3 commits into
documentdb:mainfrom
danielfrankcom:pr/floor
Open

Add $floor arithmetic expression tests#664
danielfrankcom wants to merge 3 commits into
documentdb:mainfrom
danielfrankcom:pr/floor

Conversation

@danielfrankcom

Copy link
Copy Markdown
Collaborator

This change adds tests for the $floor arithmetic expression. It was originally authored by @vic-tsang.

Closes #276

This change adds tests for the $floor arithmetic expression. It was originally
authored by @vic-tsang.

Closes documentdb#276

Co-authored-by: Victor Tsang <vitsangp@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
@danielfrankcom danielfrankcom requested a review from a team as a code owner July 1, 2026 23:38
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jul 2, 2026
@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.30 (deterministic)

Reasoning

component from path globs (test-coverage); effort from diff stats (646+0 LOC, 6 files); LLM failed: Invalid response body while trying to fetch https://api.anthropic.com/v1/messages: Premature close

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@PatersonProjects PatersonProjects left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing __init__.py

May want to consider adding dedicated bare argument test: {"$floor": "$value"}, though the case is covered by smoke.

May want to add a nested field path test case.

Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
@danielfrankcom

Copy link
Copy Markdown
Collaborator Author

Missing __init__.py

Not strictly needed here, won't add it for consistency with the other expression dirs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add compatibility test for $floor

2 participants