Skip to content

feat(seed): 可编辑 env/theme + 调试上传 40 条脱敏(#610 拆分) - #611

Merged
dofastted merged 3 commits into
mainfrom
cursor/seed-editable-env-telemetry-c7fe
Oct 19, 2026
Merged

dofastted merged 3 commits into
mainfrom
cursor/seed-editable-env-telemetry-c7fe

Conversation

@dofastted

@dofastted dofastted commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

背景

本 PR 包含

  1. 可编辑播种:种子页 settings.json 的 env 行与 theme 可直接改并随 PUT 播种;autoUpdates、grove_enabled 只读,播种时固定为 false;缺 CLAUDE_CODE_ATTRIBUTION_HEADER 时默认 0(buildSlotSettingsEnv + 前端 draft)。
  2. 调试上传(默认关):打开「调试上传」后 GET seed-settings?debug=1 返回本槽最近 40 行 telemetry-upload.log;Go sidecar 在每次 PostBatch / GrowthBook eval 落盘前脱敏邮箱、账号/组织 UUID、设备/会话 id,正文为 events 包装 JSON。

明确不含

文档

  • CHANGELOG「未发布」、docs/PANEL_API.md、docs/TELEMETRY.md

验收

相对 2bb07d84 diff 仅 15 个文件(panel seed UI/API、seed-policy 默认 attribution、worker telemetry upload log + 单测)。

Open in Web Open in Cursor 

Note

Low Risk
UI and seed-policy defaults plus optional debug read of redacted telemetry logs; no auth or inference path changes beyond existing admin seed-settings.

Reviewed by Cursor Bugbot for commit 407cc16. Configure here.

从 tip 2bb07d8 拣出种子页增量:settings.json env 与 theme 可编辑播种;
autoUpdates/grove_enabled 只读固定;缺 CLAUDE_CODE_ATTRIBUTION_HEADER 默认 0。
Go sidecar 写 telemetry-upload.log(40 行脱敏),面板 debug=1 拉取。

Co-authored-by: ted <kuhlmangarry24@gmail.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 407cc16. Configure here.

Comment thread web/src/features/vm/detail-page.tsx Outdated
})
const seed = useQuery({
...vmSeedQueryOptions(id),
...vmSeedQueryOptions(id, seedDebug),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug toggle unmounts seed form

Medium Severity

Turning on 调试上传 changes the seed query key, so React Query treats it as a cold cache miss. seed.data goes empty and the seed card unmounts into the loading placeholder, wiping any unsaved env/theme/claude.setting edits.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 407cc16. Configure here.

className='h-8 font-mono text-xs'
/>
</label>
))}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editable env rows do not persist

Medium Severity

The seed UI now treats every settings.json env row as editable and sends the whole map as extra_env. PUT still rebuilds env from slot timezone/locale and the telemetry contract afterward, so edits to TZ, LANG, kill-switch keys, Bedrock/Vertex, and CLAUDE_CODE_GATEWAY_HINT_HEADERS save as 200 then vanish from the file.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 407cc16. Configure here.

- seed-settings 稳定 queryKey;upload log 单独拉 debug=1
- TZ/kill-switch/Bedrock/Vertex/gateway hint 只读,PUT 不写 extra_env
- 单测覆盖 query 分离与只读键

Co-authored-by: ted <kuhlmangarry24@gmail.com>
Co-authored-by: ted <kuhlmangarry24@gmail.com>
@dofastted
dofastted merged commit f1ae9ba into main Oct 19, 2026
7 checks passed
dofastted added a commit that referenced this pull request Oct 19, 2026
从 tip(#611)干净重做 #612 拆分:解锁/播种确认;时区/语言 en/cn/jp;跟随 SOCKS5 经 timezone_follow_proxy,不经 extra_env。

不含 egress/migration/auto_compact/thread-betas/VERSION。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants