dat: validate archive inputs and unit completeness - #3589
Merged
ribbanya merged 3 commits intoOct 1, 2026
Merged
Conversation
Collaborator
|
You might want to hold off on this. I'm in the process of swapping to full cmake-ninja in master...ribbanya:melee:wip/dat. |
Collaborator
|
And I don't want to introduce synthetic DATs at this time. |
Collaborator
|
@itsgrimetime Hit my session limit and merged in #3590; feel free to continue on with what's still relevant. |
itsgrimetime
force-pushed
the
codex/dat-sample-build-failures
branch
from
October 1, 2026 04:54
9da8d09 to
8b002f2
Compare
Collaborator
Author
Pivoted this one to work off that |
itsgrimetime
force-pushed
the
codex/dat-sample-build-failures
branch
from
October 1, 2026 16:29
8b002f2 to
aeef8df
Compare
ribbanya
reviewed
Oct 1, 2026
itsgrimetime
marked this pull request as ready for review
October 1, 2026 17:04
ribbanya
approved these changes
Oct 1, 2026
ribbanya
left a comment
Collaborator
There was a problem hiding this comment.
Nice, this makes way more sense to look at. Later on we can try to reconstruct the dat files from source and then the completion flag will prompt a checksum between the built dat and the original.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.