Repository navigation
dat: fix symbol ordering, format generated source in-place - #3593
Merged
Merged
Conversation
- No header code in base objects: jobj.h redeclared the static inline HSD_JObjRefThis without `inline`, which made clang emit it (and iref_INC, with its assert's file name) wherever the header is included. `samples report` lists anything a base object has outside .data. - The base object's .data is laid out in the target's order, so objdiff's section match agrees with the per-symbol one. clang lays variables out where an initializer first points to them, not where they are defined, so each unit is compiled with -fdata-sections and linked (ld.lld -r) with target/<unit>.ld, which `samples slice` writes. Every unit's .data bytes now equal the target's. - Formatting in place: codegen writes src/ and the format step formats it there, with a stamp in stamp/, so there is one set of generated sources. Also: - The build runs without the dev shell's environment, as objdiff runs it: NEWLIB_INCLUDE and AURORA_SRC are cached (from the environment when set; configuring without them fails), and the LLVM tools and cargo are found by absolute path. Configuring through a symlinked path fails: the build then names files by two paths, and ninja reran CMake and rebuilt everything on every build. - User-side switches in the build's cache: MELEE_DAT_SAMPLES_ALL (archive globs) samples every typed object of those archives, and MELEE_DAT_SAMPLES_EXCLUDE (type globs) keeps types out of the samples. - objdiff is pinned to v3.8.2, which no longer needs the Cargo.lock patch. 11237 of 11239 samples match, as before; the DOL still matches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ribbanya
marked this pull request as ready for review
September 30, 2026 21:36
ribbanya
enabled auto-merge (squash)
September 30, 2026 21:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.