dat: per-archive rebuilds, complete flags, hoist dat types to TU headers - #3594
Merged
Merged
Conversation
- Per-archive type dependencies: `samples types` hashes the types each archive's roots reach and rewrites the hash only when it changes, so a header change rebuilds only the archives that use it (a stage type: the 71 Gr units, in 13 s). - objdiff `complete` for units whose types explain the whole file: every relocation, every public symbol, no walk issues (49 of 765). - Dat types declared in .c files are hoisted into their TU headers, so their data can be sampled; `types unhoisted` lists what's left (none). ftLoadCommonData, plLoadCommonData and the menu data tables are struct tags, since each shares its name with its archive symbol. - Coverage: scene and stage model-group animation/light lists are DAT_NULLTERM, the stage model group's fields are named, and the debug and sound test name tables are sized (91.5% -> 95.0% of relocations explained). - `types duplicates` finds records defined twice; ftData_x38 is merged into AbsorbDesc. - Archive externs: named slots Melee's loader sets to NULL. The walk counts them as pointers, and the samples relocate them to their names. - Generated headers group declarations as Samples, Externs and Elided; data that isn't written as C is a sized `DatBlob` array. 13564 of 13566 samples match, as before; the DOL still matches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ribbanya
marked this pull request as ready for review
September 30, 2026 22:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.