dat: counts for pointer-table roots - #3595
Merged
Merged
Conversation
ribbanya
commented
Sep 30, 2026
Collaborator
Of the 30 roots the code loads into a `T**`, 28 are tables: null-terminated lists (map_plit in the stage archives, itemdata, the scene light and model lists) or fixed-count tables (the staff roll models, the name tables). The walk followed only their first entry: when the loader gives a root's type, dat_symbols.txt couldn't add a count. - dat_symbols.txt takes a `count:N` or `count:*` attribute, which also applies to roots whose loader gives their type: the walk lays out that many of the root's type, or as many as fit before the next symbol or pointer target (a null-terminated list's null entry included). - 17 table roots get counts. - The per-archive types hash includes the count. Explained relocations 95.0% -> 95.9% (Gm 98.4%, Gr 95.3%, If 99.5%, Mn 99.3%); samples unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ribbanya
marked this pull request as ready for review
September 30, 2026 23:10
ribbanya
enabled auto-merge (squash)
September 30, 2026 23:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.