RPSysQueuedScene and RPUtlShadowDrawer OK, RPSportsCommon partially split, tons of other WIP files - #167
Merged
Conversation
Report for RSPE01_01 (1b679c1 - 915a933)📈 Matched code: 35.02% (+0.02%, +676 bytes) ✅ 8 new matches
📈 9 improvements in unmatched items
|
kiwi515
requested changes
Sep 12, 2026
|
|
||
| class RPGolCamera { | ||
| public: | ||
| RP_SINGLETON_DECL(RPGolCamera); |
Collaborator
There was a problem hiding this comment.
is this header for a different class in the binary? RPGolCamera in ghidra is a base class, not a singleton
Contributor
Author
There was a problem hiding this comment.
I just went by the splits, so I figured it was a singleton
Collaborator
There was a problem hiding this comment.
ah okay, could u remove the macro then pls :p
kiwi515
requested changes
Sep 12, 2026
|
|
||
| class RPGolCamera { | ||
| public: | ||
| RP_SINGLETON_DECL(RPGolCamera); |
Collaborator
There was a problem hiding this comment.
ah okay, could u remove the macro then pls :p
| * @brief Resource manager for Golf | ||
| */ | ||
| class RPGolResourceManager { | ||
| public: |
Collaborator
There was a problem hiding this comment.
could you move the public: down to the enum EArchive? the RP_SINGLETON_DECL macro itself contains access modifiers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.