Skip to content

Refine Bowling splits and attempt some TUs - #170

Open
Alex9303 wants to merge 6 commits into
doldecomp:masterfrom
Alex9303:Bowling
Open

Alex9303 wants to merge 6 commits into
doldecomp:masterfrom
Alex9303:Bowling

Conversation

@Alex9303

Copy link
Copy Markdown
Contributor

No description provided.

@decomp-dev

decomp-dev Bot commented Sep 20, 2026

Copy link
Copy Markdown

Report for RSPE01_01 (27fa94a - 0df8546)

📈 Matched code: 35.39% (+0.36%, +12672 bytes)
📈 Matched data: 37.67% (+0.04%, +632 bytes)

✅ 105 new matches
Unit Item Bytes Before After
main/Pack/RPSports/RPBowScene/RPBowScoreLayout RPBowScoreLayout::Init(RPSysLytResAccessor*, unsigned long) +772 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowPerfectGameUI RPBowPerfectGameUI::Calc() +684 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowPowerThrowsPinManager RPBowPowerThrowsPinManager::TransformMatrix(int, const nw4r::math::MTX34*, float) +580 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowTutorialLayout::Update() +552 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowBallHistoryEntry RPBowBallHistoryManager::RecordState(BallPhysicsState*) +536 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowAimGuideLayout RPBowAimGuideLayout::Init(EGG::Heap*, RPSysMessage*) +520 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowObstacleManager RPBowObstacleManager::ResetLaneObstacles(unsigned long, unsigned long, float) +504 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowObstacleManager .rodata +472 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowObstacleManager UpdatePinHitState(PinStatus*, RPBowObstacleManager*, unsigned long, unsigned long) +468 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowRegularPinManager RPBowRegularPinManager::HideExcessPins(int) +360 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowPowerThrowsPinManager RPBowPowerThrowsPinManager::ClearMatrices(int) +336 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowObstacleManager RPBowObstacleManager::CheckObstacleCollision(unsigned long, nw4r::math::VEC3*) +320 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowTrainingStageLayout::Update(SceneContext*) +320 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowPowerThrowsPinLayout RPBowPowerThrowsPinLayout::Init(RPSysLytResAccessor*) +316 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager RPBowGlobalLaneManager::InitializeLaneContexts(RPBowSceneObjectManager*) +300 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowEventTextLayout::Init(RPSysLytResAccessor*, RPSysMessage*) +300 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowPerfectGameUI RPBowPerfectGameUI::Init(RPSysLytResAccessor*, RPSysMessage*) +280 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowTutorialLayout::Init(RPSysLytResAccessor*, RPSysMessage*) +272 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowObstacleManager RPBowObstacleManager::CheckObstaclePassed(unsigned long, nw4r::math::VEC3*) +248 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowRegularPinManager RPBowRegularPinManager::CopyMatricesToModel(RPGrpModel*) +244 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowBallHistoryEntry RPBowBallHistoryManager::Allocate(unsigned long) +240 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowGameOverLayout::Init(RPSysLytResAccessor*, RPSysMessage*) +212 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowScoreLayout RPBowScoreLayout::InitIcons() +208 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowGameOverLayout::Update() +196 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowPinSetterModel RPBowPinSetterModel::Reset() +188 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowGuidanceLayout::Init(RPSysLytResAccessor*, RPSysMessage*) +172 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowNormalPinLayout RPBowNormalPinLayout::Init(RPSysLytResAccessor*) +168 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowBallHistoryEntry RPBowBallHistoryManager::AddThrowPosStateA(ThrowPosState_A*, int) +152 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowStrikeLayout::Init(RPSysLytResAccessor*, RPSysMessage*) +148 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowPowerThrowsStageLayout::Init(RPSysLytResAccessor*, RPSysMessage*) +144 0.00% 100.00%

...and 75 more new matches

🥀 4 broken matches
Unit Item Bytes Before After
main/Pack/RPSports/RPBowScene/RPBowPinSetter Bowling::ResetPinSetterState(Bowling::LaneContext*, unsigned char) -96 100.00% 0.00%
main/Pack/RPSports/RPBowScene/RPBowPinSetter Bowling::TriggerPinSetter(Bowling::LaneContext*, int) -36 100.00% 0.00%
main/Pack/RPSports/RPBowScene/RPBowPinSetter Bowling::IsPinSetterActive(Bowling::LaneContext*) -36 100.00% 0.00%
main/Pack/RPSports/RPBowScene/RPBowPinSetter Bowling::fn_803345F0(Bowling::LaneContext*) -4 100.00% 0.00%
📈 51 improvements in unmatched items
Unit Item Bytes Before After
main/Pack/RPSports/RPBowScene/RPBowNpcManager RPBowNpcManager::Update() +3289 0.00% 92.20%
main/Pack/RPSports/RPBowScene/RPBowRegularPinManager RPBowRegularPinManager::CalculatePinTransforms(int, float, nw4r::math::MTX34*, nw4r::math::MTX34*, nw4r::math::MTX34*) +1176 0.00% 82.38%
main/Pack/RPSports/RPBowScene/RPBowPowerThrowsRoundsLayout RPBowPowerThrowsRoundsLayout::Update(SceneContext*) +995 0.00% 98.32%
main/Pack/RPSports/RPBowScene/RPBowAimGuideLayout RPBowAimGuideLayout::Calc(SceneContext*) +908 0.00% 82.92%
main/Pack/RPSports/RPBowScene/RPBowActiveBall RPBowActiveBall::RenderModelSet() +906 0.00% 97.64%
main/Pack/RPSports/RPBowScene/RPBowPinSetterManager LaneContext::UpdatePinSetter() +803 0.00% 96.10%
main/Pack/RPSports/RPBowScene/RPBowObstacleManager RPBowObstacleManager::UpdateObstacleCollisionBounds() +793 0.00% 98.24%
main/Pack/RPSports/RPBowScene/RPBowRegularPinManager RPBowRegularPinManager::Calc() +710 0.00% 97.62%
main/Pack/RPSports/RPBowScene/RPBowTrainingLivesLayout RPBowTrainingLivesLayout::Update(SceneContext*) +703 0.00% 95.53%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowEventTextLayout::Update(SceneContext*) +694 0.00% 95.36%
main/Pack/RPSports/RPBowScene/RPBowPowerThrowsPinLayout RPBowPowerThrowsPinLayout::Update(SceneContext*) +650 0.00% 84.66%
main/Pack/RPSports/RPBowScene/RPBowPinSetterModel RPBowPinSetterModel::Calc() +632 0.00% 87.84%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowPowerThrowsStageLayout::Update(SceneContext*) +630 0.00% 94.92%
main/Pack/RPSports/RPBowScene/RPBowNormalPinLayout RPBowNormalPinLayout::Update(SceneContext*) +628 0.00% 95.76%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager .rodata +581 0.00% 99.66%
main/Pack/RPSports/RPBowScene/RPBowAlleyModelManager RPBowAlleyModelManager::UpdateModels() +566 0.00% 89.68%
main/Pack/RPSports/RPBowScene/RPBowPowerThrowsRoundsLayout RPBowPowerThrowsRoundsLayout::Init(RPSysLytResAccessor*, RPSysMessage*) +325 0.00% 99.39%
main/Pack/RPSports/RPBowScene/RPBowAimGuideLayout .rodata +293 0.00% 99.32%
main/Pack/RPSports/RPBowScene/RPBowLayoutManager RPBowStrikeLayout::Update(SceneContext*) +267 0.00% 94.37%
main/Pack/RPSports/RPBowScene/RPBowTrainingLivesLayout RPBowTrainingLivesLayout::Init(RPSysLytResAccessor*) +261 0.00% 99.17%
main/Pack/RPSports/RPBowScene/RPBowScoreLayout .rodata +229 0.00% 98.91%
main/Pack/RPSports/RPBowScene/RPBowPowerThrowsPinManager RPBowPowerThrowsPinManager::CopyMatrices(RPGrpModel*) +227 0.00% 93.25%
main/Pack/RPSports/RPBowScene/RPBowNpcManager RPBowNpcManager::DebugPrintNpcState() +152 0.00% 60.37%
main/Pack/RPSports/RPBowScene/RPBowTrainingLivesLayout .rodata +133 0.00% 98.51%
main/Pack/RPSports/RPBowScene/RPBowPowerThrowsRoundsLayout .rodata +127 0.00% 99.61%
main/Pack/RPSports/RPBowScene/RPBowActiveBall RPBowActiveBall::~RPBowActiveBall() +88 0.00% 95.65%
main/Pack/RPSports/RPBowScene/RPBowAlleyModelManager RPBowAlleyModelManager::~RPBowAlleyModelManager() +88 0.00% 95.65%
main/Pack/RPSports/RPBowScene/RPBowPinSetterModel RPBowPinSetterModel::~RPBowPinSetterModel() +88 0.00% 95.65%
main/Pack/RPSports/RPBowScene/RPBowPowerThrowsPinLayout .rodata +87 0.00% 99.43%
main/Pack/RPSports/RPBowScene/RPBowPowerThrowsPinManager RPBowPowerThrowsPinManager::~RPBowPowerThrowsPinManager() +72 0.00% 78.26%

...and 21 more improvements in unmatched items

📉 3 regressions in unmatched items
Unit Item Bytes Before After
main/Pack/RPSports/RPBowScene/RPBowPinSetter Bowling::UpdatePinSetter(Bowling::LaneContext*) -803 96.10% 0.00%
main/Pack/RPSports/RPBowScene/RPBowPinSetter .sdata2 -36 90.91% 0.00%
main/Pack/RPSports/RPBowScene/RPBowBackgroundNpcManager fn_8034E96C -1 20.00% 0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant