Skip to content

RPSportsMenuBgModel, RPGraphics Rev 0 libraries, BTE WIP - #171

Open
Tanline666 wants to merge 3 commits into
doldecomp:masterfrom
Tanline666:sports-common-misc
Open

Tanline666 wants to merge 3 commits into
doldecomp:masterfrom
Tanline666:sports-common-misc

Conversation

@Tanline666

Copy link
Copy Markdown
Contributor

Bonus is that this go-around for BTE removes a few extraneous libraries that were bloating the header. Plus, Rev 0 support!

@decomp-dev

decomp-dev Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Report for RSPE01_00 (27fa94a - 2359475)

[!] Base report not found. Either the build or webhook failed on the base branch or this version was just added in this PR.


Report for RSPE01_01 (27fa94a - 2359475)

📈 Matched code: 35.26% (+0.24%, +8256 bytes)
📈 Linked code: 29.14% (+0.21%, +7212 bytes)
📈 Matched data: 48.60% (+10.97%, +166624 bytes)
📈 Linked data: 65.18% (+11.00%, +166952 bytes)

✅ 52 new matches
Unit Item Bytes Before After
main/revolution/BTE/rvl/gki_ppc .bss +166624 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_create_pool +840 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer gki_buffer_init +684 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer gki_init_free_queue +544 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_send_msg +444 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_getbuf +416 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_freebuf +368 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_delete_pool +352 0.00% 100.00%
main/revolution/BTE/gki/common/gki_time GKI_start_timer +336 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_enqueue_head +320 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_enqueue +316 0.00% 100.00%
main/revolution/BTE/gki/common/gki_time GKI_remove_from_timer_list +292 0.00% 100.00%
main/revolution/BTE/gki/common/gki_time GKI_add_to_timer_list +236 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_getpoolbuf +232 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_remove_from_queue +196 0.00% 100.00%
main/revolution/BTE/gki/common/gki_time gki_timers_init +188 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_read_mbox +176 0.00% 100.00%
main/revolution/BTE/rvl/gki_ppc GKI_shutdown +168 0.00% 100.00%
main/egg/gfxe/eggLightObject EGG::LightObject::CalcDirDist() +164 0.00% 100.00%
main/Pack/RPSports/RPSportsCommon/RPSportsMenuBgModel RPSportsMenuBgModel::calcView() +164 0.00% 100.00%
main/revolution/BTE/rvl/gki_ppc GKI_send_event +164 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_dequeue +160 0.00% 100.00%
main/Pack/RPGraphics/RPGrpRenderer RPGrpRenderer::Begin() +152 0.00% 100.00%
main/revolution/BTE/rvl/gki_ppc GKI_init +144 0.00% 100.00%
main/revolution/BTE/gki/common/gki_time GKI_update_timer_list +140 0.00% 100.00%
main/revolution/BTE/gki/common/gki_time GKI_stop_timer +136 0.00% 100.00%
main/Pack/RPGraphics/RPGrpRenderer RPGrpRenderer::StartDebugDraw() +128 0.00% 100.00%
main/egg/gfxe/eggLightManager EGG::LightManager::SetChanAmbColor() const +120 0.00% 100.00%
main/Pack/RPSports/RPSportsCommon/RPSportsMenuBgModel RPSportsMenuBgModel::~RPSportsMenuBgModel() +88 0.00% 100.00%
main/revolution/BTE/gki/common/gki_buffer GKI_get_buf_size +68 0.00% 100.00%

...and 22 more new matches

📈 19 improvements in unmatched items
Unit Item Bytes Before After
main/Pack/RPSports/RPSportsCommon/RPSportsMenuBgModel RPSportsMenuBgModel::createData(EGG::Archive*) +331 0.00% 65.85%
main/revolution/BTE/gki/common/gki_buffer .data +324 0.00% 99.08%
main/Pack/RPSports/RPSportsCommon/RPSportsMenuBgModel RPSportsMenuBgModel::RPSportsMenuBgModel(unsigned char, unsigned char, unsigned short) +290 0.00% 63.17%
main/Pack/RPSports/RPSportsCommon/RPSportsMenuBgModel RPSportsMenuBgModel::initCamera() +205 0.00% 67.61%
main/egg/gfxe/eggLightObject EGG::LightObject::CalcView(const nw4r::math::MTX34&) +156 0.00% 27.82%
main/egg/gfxe/eggLightObject EGG::LightObject::InitGX(_GXLightObj*) const +136 0.00% 20.55%
main/Pack/RPGraphics/RPGrpRenderer RPGrpRenderer::CreateView3D(unsigned char, RPGrpCamera*, RPGrpScreen*) +104 0.00% 69.05%
main/Pack/RPGraphics/RPGrpModelScene RPGrpModelScene::~RPGrpModelScene() +62 0.00% 49.03%
main/Pack/RPGraphics/RPGrpRenderer .data +44 0.00% 18.33%
main/egg/gfxe/eggLightObject .rodata +41 0.00% 26.09%
main/Pack/RPSports/RPSportsCommon/RPSportsMenuBgModel .rodata +38 0.00% 97.44%
main/egg/gfxe/eggLightObject EGG::LightObject::Calc() +32 0.00% 11.41%
main/Pack/RPSports/RPSportsCommon/RPSportsMenuBgModel .data +31 0.00% 44.14%
main/Pack/RPGraphics/RPGrpRenderer RPGrpRenderer::AppendDrawObject(IRPGrpDrawObject*) +27 0.00% 76.56%
main/Pack/RPSports/RPSportsCommon/RPSportsMenuBgModel .sdata2 +22 0.00% 55.56%
main/egg/gfxe/eggLightObject .sdata2 +19 0.00% 30.95%
main/Pack/RPGraphics/RPGrpRenderer .sdata2 +13 0.00% 41.67%
main/Pack/RPGraphics/RPGrpRenderer .sdata +6 0.00% 75.00%
main/egg/gfxe/eggLightManager .sdata2 +1 0.00% 12.50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant