Skip to content

refactor(skills): rename legacy skills to dot- convention#36469

Open
nollymar wants to merge 5 commits into
worktree-skill-governancefrom
skill-rename-legacy
Open

refactor(skills): rename legacy skills to dot- convention#36469
nollymar wants to merge 5 commits into
worktree-skill-governancefrom
skill-rename-legacy

Conversation

@nollymar

@nollymar nollymar commented Jul 8, 2026

Copy link
Copy Markdown
Member

Follow-up to #36466. Tracked by #36467.

Stacked PR — base is worktree-skill-governance (needs skills.config.json + skill-lint). Retarget to main after #36466 merges.

What

Brings the pre-dot- first-party skills into convention and adds required owner/status frontmatter, so they pass skill-lint as full first-party skills (removed from the grandfather list). Result: skill-lint passes with 0 warnings.

Old New Domain added?
triage dot-issue-triage
dotcms-github-issues dot-issue-manage
cicd-diagnostics dot-cicd-diagnose
lts-backport dot-release-backport-lts
check-release-rollback dot-release-rollback-check + added missing frontmatter
vtl-migration dot-ui-vtl-migration
sdk-analytics dot-sdk-analytics sdk

skill-doctor stays grandfathered — it's a vendored/generic skill we didn't author, so it keeps its upstream name and no dot- prefix.

References updated (so nothing breaks)

  • /create-issue, /query-issue, /find-issues, /update-issue command bodies → point at dot-issue-manage
  • /check-release-rollback command body → dot-release-rollback-check
  • settings.json permission paths → dot-cicd-diagnose
  • Each renamed skill's internal self-path references (.claude/skills/<old>/…)

⚠️ Two things for reviewers to confirm

  1. Owners are best-guess placeholders (@dotcms/scout / @dotcms/platform) — please correct to the real owning teams.
  2. Directly-invoked skills change their slash-command name: /triage → /dot-issue-triage, /cicd-diagnostics → /dot-cicd-diagnose, /lts-backport → /dot-release-backport-lts, /vtl-migration → /dot-ui-vtl-migration, /sdk-analytics → /dot-sdk-analytics. Command-fronted skills (issue commands, rollback check) keep their command names. If any /old-name muscle memory is heavily used, we can add thin alias commands — flag it.

Verified

just skills-lint → ✅ pass, 8 first-party skills, 0 warnings (was 3 legacy warnings before). Catalog regenerated. Swept for stale old-name references — none remain in tracked files.

🤖 Generated with Claude Code

Bring pre-dot- first-party skills into the naming convention and add
required owner/status frontmatter, so they pass skill-lint as full
first-party skills (no longer grandfathered).

Renames:
- triage                 -> dot-issue-triage
- dotcms-github-issues   -> dot-issue-manage
- cicd-diagnostics       -> dot-cicd-diagnose
- lts-backport           -> dot-release-backport-lts
- check-release-rollback -> dot-release-rollback-check (also added missing frontmatter)
- vtl-migration          -> dot-ui-vtl-migration
- sdk-analytics          -> dot-sdk-analytics (added 'sdk' domain)

- skill-doctor stays grandfathered (vendored/generic, not dot- prefixed)
- Updated all references: /create|query|find|update-issue and
  /check-release-rollback command bodies, settings.json paths, and
  each skill's internal self-path references
- owner values are best-guess placeholders — teams must confirm

Note: skills invoked directly change slash-command name (e.g. /triage ->
/dot-issue-triage). Command-fronted skills keep their command names.

Stacked on the skill-governance base branch. Part of #36467.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@mergify

mergify Bot commented Jul 8, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@claude

claude Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @nollymar's task in 3m 15s —— View job


Review — rename legacy skills to dot- convention

  • Fetch base branch & compute diff
  • Review renamed skill frontmatter (owner/status/domain)
  • Verify reference updates (commands, settings, catalog, self-paths)
  • Sweep for stale old-name references
  • Post review

I reviewed the committed changes at HEAD against origin/worktree-skill-governance. This is a rename + reference-update PR (no runtime code paths), so I focused on frontmatter validity, reference consistency, and stale-name leakage.

New Issues

No issues found.

Verification performed

Frontmatter — all 7 renamed skills carry valid name/owner/status/description. Each name satisfies the lint regex ^dot-(issue|pr|release|cicd|content|ui|sdk)-… (skill-lint.mjs:15), including the multi-segment dot-release-backport-lts and dot-release-rollback-check. The new sdk domain is correctly added to approvedDomains in skills.config.json, which is what makes dot-sdk-analytics legal.

References — spot-checked at HEAD (working tree is mid-rename and misleading, so I verified against the committed tree):

  • /create-issue, /query-issue, /find-issues, /update-issue → all point at dot-issue-manage
  • /check-release-rollback command body → dot-release-rollback-check
  • settings.json permission paths → dot-cicd-diagnose
  • CATALOG.md regenerated: 8 first-party skills, correct owners/statuses, skill-doctor correctly shown as _legacy_

Stale-name sweepgit grep at HEAD for old skill dirs (skills/{triage,dotcms-github-issues,cicd-diagnostics,lts-backport,vtl-migration,sdk-analytics}/) and old backtick/command names across commands, settings, catalog, .mise.md, and each renamed skill's internal self-paths: no stale references remain. ✅

Notes (non-blocking)

  • 🟡 .mise.md:~180 — the "CI/CD Diagnostics Skill" section lists fetch-logs.py, fetch-jobs.py, fetch-metadata.py, but the skill actually ships diagnose.py (with those as subcommands). This is a pre-existing doc mismatch that predates this PR — the PR only updated the dot- prefix on these lines, not the filenames — so out of scope here. Worth a cleanup pass later.
  • Per the PR body's own callout: owners are now filled in (@dotcms/scout, @dotcms/platform, @dotcms/falcon) — confirm these are the real owning teams. And the 5 directly-invoked skills change their slash-command names (/triage → /dot-issue-triage, etc.); the command-fronted skills keep their command names, so no muscle-memory break there.

LGTM — clean rename, references consistent, lint should pass with 0 warnings as claimed.

@nollymar nollymar linked an issue Jul 8, 2026 that may be closed by this pull request
10 tasks
nollymar and others added 2 commits July 10, 2026 18:03
Resolve skills.config.json conflict: keep both the 'sdk' approved domain
(this PR) and the 'deprecated' valid status (base branch).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Set owner to @dotCMS/falcon for dot-sdk-analytics and dot-ui-vtl-migration
- Fix stale .claude/skills/cicd-diagnostics/ path refs in .mise.md → dot-cicd-diagnose
- Fix stale /cicd-diagnostics slash-command and dir tree in dot-cicd-diagnose/README.md
- Fix stale /lts-backport slash-command refs in dot-release-backport-lts/SKILL.md
- Regenerate CATALOG.md

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Skill governance: dot- naming convention, catalog, lint & CI gate

1 participant