Documents the OpenApiGenerationEnvironment MSBuild property - #37589
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
@wadepickett For other features, it looks like we are not consistent in file names whether we use the preview version number in file name or not. Do you have recommendation?
There was a problem hiding this comment.
@Youssef1313, You are right, it is not consistant, thanks for pointing out the issue. I don't see a reason for keeping the preview versions in the file name for the What's new include files. I think they just started that way long ago at some point and then were perpetuated. I think even the current AI agent related to this is includijng them, which I'll fix.
.
So this:
aspnetcore/release-notes/aspnetcore-11/includes/openapi-generation-environment-preview-7.md
Would become:
aspnetcore/release-notes/aspnetcore-11/includes/openapi-generation-environment.md
I will fix all of them in a new PR after this one.
There was a problem hiding this comment.
I went ahead and fixed the new file name here. I will correct the rest of them in a new PR.
…ion-environment.md
Updated OpenAPI generation environment include file reference.
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
@snemeckayova & @Youssef1313: Approved. This looks great, I did not find any new issues. I did update the file name of the new What's New include file.
There was a problem hiding this comment.
@Youssef1313, You are right, it is not consistant, thanks for pointing out the issue. I don't see a reason for keeping the preview versions in the file name for the What's new include files. I think they just started that way long ago at some point and then were perpetuated. I think even the current AI agent related to this is includijng them, which I'll fix.
.
So this:
aspnetcore/release-notes/aspnetcore-11/includes/openapi-generation-environment-preview-7.md
Would become:
aspnetcore/release-notes/aspnetcore-11/includes/openapi-generation-environment.md
I will fix all of them in a new PR after this one.
There was a problem hiding this comment.
I went ahead and fixed the new file name here. I will correct the rest of them in a new PR.
|
Since I made the last commit I think we need one more approval from you @Youssef1313 in order to merge. Was this intended to merge to live rigth away today or wait until the next .NET 11 release? |
Youssef1313
left a comment
Youssef1313
left a comment
There was a problem hiding this comment.
LGTM.
Given this shipped in Preview 7 already, I think it's fine to go live.
I didn't know if we were adding anything newer in the mix of it. Got it. Thanks, will go live now. |
3 participants
Summary
Documents the OpenApiGenerationEnvironment MSBuild property introduced by dotnet/aspnetcore#63856.
Changes
aspnetcore-openapi.md: Explains how to select the app environment used during build-time OpenAPI document generation.openapi-generation-environment-preview-7.md: Adds the .NET 11 feature announcement, configuration example, and contributor acknowledgment.aspnetcore-11.md: Adds the new OpenAPI release-note include.Fixes dotnet/aspnetcore#68949
Internal previews
Build report