[tests] Don't let run-bare's recursive make trip the RUNTIMEIDENTIFIER guard. - #26360
[tests] Don't let run-bare's recursive make trip the RUNTIMEIDENTIFIER guard.#26360rolfbjarne wants to merge 1 commit into
Conversation
…R guard. The makefile exports RUNTIMEIDENTIFIER (or RUNTIMEIDENTIFIERS) from RID. The '$(MAKE) delete-saved-state' recursion in run-bare inherited that exported value and tripped the guard that forbids setting RUNTIMEIDENTIFIER(S) directly, so run-bare failed after the test app exited successfully. Clear the variables for the run-bare target, mirroring what run-old already does. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes run-bare in the .NET test makefile so that its recursive $(MAKE) delete-saved-state invocation doesn’t inherit exported RUNTIMEIDENTIFIER(S) values (derived from RID) and trip the makefile guard that forbids setting RUNTIMEIDENTIFIER(S) directly.
Changes:
- Clear exported
RUNTIMEIDENTIFIERandRUNTIMEIDENTIFIERSfor therun-baretarget to prevent sub-make guard failures. - Add an explanatory comment documenting why those exports are cleared.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🔥 [CI Build #549a674] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 2 tests failed, 201 tests passed. Failures❌ monotouch tests (iOS)1 tests failed, 18 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Tahoe (26) tests1 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
The makefile exports RUNTIMEIDENTIFIER (or RUNTIMEIDENTIFIERS) from RID. The
'$(MAKE) delete-saved-state' recursion in run-bare inherited that exported
value and tripped the guard that forbids setting RUNTIMEIDENTIFIER(S)
directly, so run-bare failed after the test app exited successfully. Clear
the variables for the run-bare target, mirroring what run-old already does.