Make Uri non-ASCII hex unescaping a bit faster#131387
Open
MihaZupan wants to merge 2 commits into
Open
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates System.Private.Uri’s percent-unescape helper to reduce overhead when decoding non-ASCII UTF-8 bytes from %xx sequences, primarily by switching to HexConverter table lookups and tightening bounds checks in the hot loop.
Changes:
- Replaces manual hex-nibble decoding with
HexConverter.FromCharlookups for%xxparsing. - Adjusts the bounds check around reading
%+ 2 hex chars to a form intended to help the JIT elide bounds checks. - Adds a guard intended to prevent invalid hex from slipping past the ASCII-range check (but the current guard is insufficient and introduces a correctness bug; see review comment).
This was referenced Jul 26, 2026
EgorBo
reviewed
Jul 26, 2026
| int i = totalCharsConsumed + (bytesLeftInBuffer * 3); | ||
|
|
||
| ReadByteFromInput: | ||
| if ((uint)(input.Length - i) <= 2 || input[i] != '%') |
EgorBo
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid some bounds checks and use a table lookup instead of manual hex calculations.
Closes #121413, followup to #121016